mirror of
https://github.com/servo/servo.git
synced 2025-08-06 14:10:11 +01:00
Auto merge of #21310 - jdm:canvas-path, r=pcwalton
Improve rendering of transformed 2d paths This makes http://webglreport.com/ render correctly by porting the [equivalent code](https://searchfox.org/mozilla-central/rev/196560b95f191b48ff7cba7c2ba9237bba6b5b6a/dom/canvas/CanvasRenderingContext2D.h#847-875) from Gecko's 2d canvas implementation that handles paths with transformations. The first commit fixes the rendering issue, and the second commit fixes some new test failures that were exposed by that change. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21169 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21310) <!-- Reviewable:end -->
This commit is contained in:
commit
3d4a416c6b
11 changed files with 327 additions and 97 deletions
|
@ -1,5 +0,0 @@
|
|||
[2d.path.arcTo.scale.html]
|
||||
type: testharness
|
||||
[arcTo scales the curve, not just the control points]
|
||||
expected: FAIL
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
[2d.path.arcTo.transformation.html]
|
||||
type: testharness
|
||||
[arcTo joins up to the last subpath point correctly]
|
||||
expected: FAIL
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
[2d.path.clip.unaffected.html]
|
||||
type: testharness
|
||||
[Canvas test: 2d.path.clip.unaffected]
|
||||
expected: FAIL
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
[2d.path.fill.closed.unaffected.html]
|
||||
type: testharness
|
||||
[Canvas test: 2d.path.fill.closed.unaffected]
|
||||
expected: FAIL
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
[2d.path.isPointInPath.transform.2.html]
|
||||
type: testharness
|
||||
[isPointInPath() handles transformations correctly]
|
||||
expected: FAIL
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
[2d.path.isPointInPath.transform.4.html]
|
||||
type: testharness
|
||||
[isPointInPath() handles transformations correctly]
|
||||
expected: FAIL
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
[2d.path.stroke.scale1.html]
|
||||
type: testharness
|
||||
[Stroke line widths are scaled by the current transformation matrix]
|
||||
expected: FAIL
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
[2d.path.stroke.unaffected.html]
|
||||
type: testharness
|
||||
[Stroking does not start a new path or subpath]
|
||||
expected: FAIL
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
[2d.path.transformation.basic.html]
|
||||
type: testharness
|
||||
[Canvas test: 2d.path.transformation.basic]
|
||||
expected: FAIL
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
[2d.path.transformation.changing.html]
|
||||
type: testharness
|
||||
[Transformations are applied while building paths, not when drawing]
|
||||
expected: FAIL
|
||||
|
Loading…
Add table
Add a link
Reference in a new issue