Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-22 05:45:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

clippy: Fix last few warnings (#32270)

Browse source 
* Fix clippy in components/script

warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do (components/script/dom/htmlformelement.rs:896:20)

warning: `Box::new(_)` of default value (components/script/dom/paintworkletglobalscope.rs:291:29)

warning: this creates an owned instance just for comparison (components/script/dom/radionodelist.rs:105:50)

* Fix clippy in layout_thread (2013 and 2020)

warning: this `if` statement can be collapsed (components/layout_thread/lib.rs:876:17)

warning: the following explicit lifetimes could be elided: 'a (components/layout_thread/lib.rs:239 and 2020 same line)

warning: deref which would be done by auto-deref (components/layout_thread/lib.rs:500 and 1289)

warning: dereferencing a tuple pattern where every element takes a reference (components/layout_thread/lib.rs:503,1562 and 2020 line 1153)

warning: useless conversion to the same type: `style::invalidation::element::restyle_hints::RestyleHint` (components/layout_thread_2020/lib.rs:742:36)

* Fix clippy in components/servo

warning: constants have by default a `'static` lifetime (components/servo/lib.rs:1238:31)

warning: creating a `let` binding to a value of unit type, which usually
can't be used afterwards (5 occurances in components/servo/lib.rs)

* FIx clippy in ports/servoshell

warning: this expression creates a reference which is immediately dereferenced by the compiler (ports/servoshell/app.rs:251:89)

warning: using `clone` on type `Option<TopLevelBrowsingContextId>` which implements the `Copy` trait (ports/servoshell/webview.rs:122:9)
This commit is contained in:
Pi-Cla 2024-05-12 08:43:08 +00:00 • committed by GitHub
parent 1f6d358cf9
commit 3d4fd0e550
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 49 additions and 55 deletions
Download patch file Download diff file Expand all files Collapse all files

2
ports/servoshell/app.rs
View file

@ -248,7 +248,7 @@ impl App {
window_id: _,
} => {
let response =
minibrowser.on_window_event(window.winit_window().unwrap(), &event);
minibrowser.on_window_event(window.winit_window().unwrap(), event);
// Update minibrowser if there's resize event to sync up with window.
if let WindowEvent::Resized(_) = event {
minibrowser.update(

2
ports/servoshell/webview.rs
View file

@ -119,7 +119,7 @@ where
}
pub fn focused_webview_id(&self) -> Option<WebViewId> {
self.focused_webview_id.clone()
self.focused_webview_id
}
pub fn current_url_string(&self) -> Option<&str> {