Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 20:50:07 +01:00
Code Issues Projects Releases Packages Wiki Activity

Defend against bugs in SelectorFlagsMap

Browse source 
* Make `SelectorFlagsMap::apply_flags` private so it's easier to ensure
  it is called from the correct thread.

* Clear the cache and the map at the same time; otherwise it leaves
  `SelectorFlagsMap` in an inconsistent state.
This commit is contained in:
Matt Brubeck 2017-12-07 16:45:04 -08:00
parent 1f22041f5f
commit 3e34c0295e
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
components/style/context.rs
View file

@ -553,8 +553,9 @@ impl<E: TElement> SelectorFlagsMap<E> {
}
/// Applies the flags. Must be called on the main thread.
pub fn apply_flags(&mut self) {
fn apply_flags(&mut self) {
debug_assert!(thread_state::get() == ThreadState::LAYOUT);
self.cache.evict_all();
for (el, flags) in self.map.drain() {
unsafe { el.set_selector_flags(flags); }
}