From 853d7c4819604a8a60c26bf23154e2e6ab70ba8f Mon Sep 17 00:00:00 2001 From: Cameron Zwarich Date: Sat, 24 May 2014 21:17:05 -0700 Subject: [PATCH] Eliminate pointless copies of ImageResponseMsg in the image task. --- src/components/net/image_cache_task.rs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/components/net/image_cache_task.rs b/src/components/net/image_cache_task.rs index 2bb8b22323b..5ff85b771a2 100644 --- a/src/components/net/image_cache_task.rs +++ b/src/components/net/image_cache_task.rs @@ -58,13 +58,12 @@ pub enum ImageResponseMsg { impl Eq for ImageResponseMsg { fn eq(&self, other: &ImageResponseMsg) -> bool { - // FIXME: Bad copies - match (self.clone(), other.clone()) { - (ImageReady(..), ImageReady(..)) => fail!("unimplemented comparison"), - (ImageNotReady, ImageNotReady) => true, - (ImageFailed, ImageFailed) => true, + match (self, other) { + (&ImageReady(..), &ImageReady(..)) => fail!("unimplemented comparison"), + (&ImageNotReady, &ImageNotReady) => true, + (&ImageFailed, &ImageFailed) => true, - (ImageReady(..), _) | (ImageNotReady, _) | (ImageFailed, _) => false + (&ImageReady(..), _) | (&ImageNotReady, _) | (&ImageFailed, _) => false } }