Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 04:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

clippy: Fix needless borrow warnings (#31813)

Browse source
This commit is contained in:
Oluwatobi Sofela 2024-03-21 18:48:54 +01:00 • committed by GitHub
parent 694e86ecff
commit 3e63f8d6ee
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
42 changed files with 151 additions and 157 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/bindings/htmlconstructor.rs
View file

@ -145,7 +145,7 @@ unsafe fn html_constructor(
// Step 6
rooted!(in(*cx) let mut prototype = ptr::null_mut::<JSObject>());
get_desired_proto(cx, &call_args, proto_id, creator, prototype.handle_mut())?;
get_desired_proto(cx, call_args, proto_id, creator, prototype.handle_mut())?;
let entry = definition.construction_stack.borrow().last().cloned();
let result = match entry {

4
components/script/dom/bindings/root.rs
View file

@ -121,7 +121,7 @@ where
if self.0.reflector().get_jsobject().is_null() {
self.0.trace(tracer);
} else {
trace_reflector(tracer, "on stack", &self.0.reflector());
trace_reflector(tracer, "on stack", self.0.reflector());
}
}
}
@ -718,7 +718,7 @@ where
F: FnOnce() -> DomRoot<T>,
{
assert_in_script();
&self.ptr.get_or_init(|| Dom::from_ref(&cb()))
self.ptr.get_or_init(|| Dom::from_ref(&cb()))
}
}

6
components/script/dom/bindings/structuredclone.rs
View file

@ -65,7 +65,7 @@ unsafe fn read_blob(
&mut index as *mut u32
));
let storage_key = StorageKey { index, name_space };
if <Blob as Serializable>::deserialize(&owner, &mut sc_holder, storage_key.clone()).is_ok() {
if <Blob as Serializable>::deserialize(owner, sc_holder, storage_key.clone()).is_ok() {
let blobs = match sc_holder {
StructuredDataHolder::Read { blobs, .. } => blobs,
_ => panic!("Unexpected variant of StructuredDataHolder"),
@ -171,7 +171,7 @@ unsafe extern "C" fn read_transfer_callback(
let owner = GlobalScope::from_context(cx, InRealm::Already(&in_realm_proof));
if let Ok(_) = <MessagePort as Transferable>::transfer_receive(
&owner,
&mut sc_holder,
sc_holder,
extra_data,
return_object,
) {
@ -195,7 +195,7 @@ unsafe extern "C" fn write_transfer_callback(
*tag = StructuredCloneTags::MessagePort as u32;
*ownership = TransferableOwnership::SCTAG_TMO_CUSTOM;
let mut sc_holder = &mut *(closure as *mut StructuredDataHolder);
if let Ok(data) = port.transfer(&mut sc_holder) {
if let Ok(data) = port.transfer(sc_holder) {
*extra_data = data;
return true;
}