From 1ebc1382ce44af71f7758b061d94a9b6a4f4f0e9 Mon Sep 17 00:00:00 2001 From: Michael Wilson Date: Tue, 21 Nov 2017 21:47:41 -0800 Subject: [PATCH] moving :dir() param serialization FIXME --- components/style/gecko/selector_parser.rs | 1 - components/style/selector_parser.rs | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/components/style/gecko/selector_parser.rs b/components/style/gecko/selector_parser.rs index 75e53a01db4..827e832ebcd 100644 --- a/components/style/gecko/selector_parser.rs +++ b/components/style/gecko/selector_parser.rs @@ -96,7 +96,6 @@ impl ToCss for NonTSPseudoClass { }, )* NonTSPseudoClass::Dir(ref dir) => { dest.write_str(":dir(")?; - // FIXME: This should be escaped as an identifier; see #19231 (**dir).to_css(dest)?; return dest.write_char(')') }, diff --git a/components/style/selector_parser.rs b/components/style/selector_parser.rs index ac44cc0135a..b4870557cc2 100644 --- a/components/style/selector_parser.rs +++ b/components/style/selector_parser.rs @@ -191,6 +191,7 @@ impl ToCss for Direction { let dir_str = match *self { Direction::Rtl => "rtl", Direction::Ltr => "ltr", + // FIXME: This should be escaped as an identifier; see #19231 Direction::Other(ref other) => other, }; dest.write_str(dir_str)