From 3fc5bf87d3fd605da7510a5a0240dac0157a9743 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= <emilio@crisal.io>
Date: Fri, 9 Mar 2018 01:08:36 +0100
Subject: [PATCH] style: Fix serialization of place-items.

If the justify-items / align-items value has the `legacy` bit or anything like
that we shouldn't serialize it, just as we don't parse it.

Bug: 1339656
Reviewed-by: xidorn
MozReview-Commit-ID: JsM4NrePEU6
---
 .../properties/shorthand/position.mako.rs     | 23 ++++++++++++-------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/components/style/properties/shorthand/position.mako.rs b/components/style/properties/shorthand/position.mako.rs
index 53e4edbc500..971f74ddb8f 100644
--- a/components/style/properties/shorthand/position.mako.rs
+++ b/components/style/properties/shorthand/position.mako.rs
@@ -722,8 +722,10 @@
         }
     }
 
-    pub fn parse_value<'i, 't>(context: &ParserContext, input: &mut Parser<'i, 't>)
-                               -> Result<Longhands, ParseError<'i>> {
+    pub fn parse_value<'i, 't>(
+        context: &ParserContext,
+        input: &mut Parser<'i, 't>,
+    ) -> Result<Longhands, ParseError<'i>> {
         let align = AlignItems::parse(context, input)?;
         if align.has_extra_flags() {
             return Err(input.new_custom_error(StyleParseErrorKind::UnspecifiedError));
@@ -742,13 +744,18 @@
 
     impl<'a> ToCss for LonghandsToSerialize<'a> {
         fn to_css<W>(&self, dest: &mut CssWriter<W>) -> fmt::Result where W: fmt::Write {
-            if self.align_items.0 == self.justify_items.0 {
-                self.align_items.to_css(dest)
-            } else {
-                self.align_items.to_css(dest)?;
-                dest.write_str(" ")?;
-                self.justify_items.to_css(dest)
+            if self.align_items.has_extra_flags() ||
+               self.justify_items.has_extra_flags() {
+                return Ok(());
             }
+
+            self.align_items.to_css(dest)?;
+            if self.align_items.0 != self.justify_items.0 {
+                dest.write_str(" ")?;
+                self.justify_items.to_css(dest)?;
+            }
+
+            Ok(())
         }
     }
 </%helpers:shorthand>