style: Rename SheetRebuildKind::rebuild_invalidation to should_rebuild_invalidation.

Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
This commit is contained in:
Emilio Cobos Álvarez 2017-08-23 14:06:44 +02:00
parent e648dd7822
commit 3fd8a534d7
No known key found for this signature in database
GPG key ID: 056B727BB9C1027C
2 changed files with 17 additions and 13 deletions

View file

@ -94,7 +94,7 @@ pub enum SheetRebuildKind {
impl SheetRebuildKind { impl SheetRebuildKind {
/// Whether the stylesheet invalidation data should be rebuilt. /// Whether the stylesheet invalidation data should be rebuilt.
pub fn rebuild_invalidation(&self) -> bool { pub fn should_rebuild_invalidation(&self) -> bool {
matches!(*self, SheetRebuildKind::Full) matches!(*self, SheetRebuildKind::Full)
} }
} }

View file

@ -216,7 +216,7 @@ impl DocumentCascadeData {
let origin_cascade_data = let origin_cascade_data =
self.per_origin.borrow_mut_for_origin(&origin); self.per_origin.borrow_mut_for_origin(&origin);
if rebuild_kind.rebuild_invalidation() { if rebuild_kind.should_rebuild_invalidation() {
origin_cascade_data origin_cascade_data
.effective_media_query_results .effective_media_query_results
.saw_effective(stylesheet); .saw_effective(stylesheet);
@ -274,7 +274,7 @@ impl DocumentCascadeData {
map.insert(rule, quirks_mode); map.insert(rule, quirks_mode);
if rebuild_kind.rebuild_invalidation() { if rebuild_kind.should_rebuild_invalidation() {
origin_cascade_data origin_cascade_data
.invalidation_map .invalidation_map
.note_selector(selector, quirks_mode); .note_selector(selector, quirks_mode);
@ -299,20 +299,24 @@ impl DocumentCascadeData {
} }
origin_cascade_data.rules_source_order += 1; origin_cascade_data.rules_source_order += 1;
} }
CssRule::Import(ref lock) if rebuild_kind.rebuild_invalidation() => { CssRule::Import(ref lock) => {
let import_rule = lock.read_with(guard); if rebuild_kind.should_rebuild_invalidation() {
origin_cascade_data let import_rule = lock.read_with(guard);
.effective_media_query_results origin_cascade_data
.saw_effective(import_rule); .effective_media_query_results
.saw_effective(import_rule);
}
// NOTE: effective_rules visits the inner stylesheet if // NOTE: effective_rules visits the inner stylesheet if
// appropriate. // appropriate.
} }
CssRule::Media(ref lock) if rebuild_kind.rebuild_invalidation() => { CssRule::Media(ref lock) => {
let media_rule = lock.read_with(guard); if rebuild_kind.should_rebuild_invalidation() {
origin_cascade_data let media_rule = lock.read_with(guard);
.effective_media_query_results origin_cascade_data
.saw_effective(media_rule); .effective_media_query_results
.saw_effective(media_rule);
}
} }
CssRule::Keyframes(ref keyframes_rule) => { CssRule::Keyframes(ref keyframes_rule) => {
let keyframes_rule = keyframes_rule.read_with(guard); let keyframes_rule = keyframes_rule.read_with(guard);