Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 13:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #22751 - learning:learning-patch-windows-dependencies, r=ferjm

Browse source 
Correct the GStreamer PATH for windows

<!-- Please describe your changes on the following line: -->
Just like what I said, `LNK1181` error when building `servo`:
https://github.com/servo/servo/issues/22737#issuecomment-456123020

The `gstplayer-1.0.lib` is not found, it located in `C:\gstreamer\1.0\x86_64\lib`, not `C:\gstreamer\1.0\x86_64\bin`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [X] `./mach build -r` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] These changes do not require tests because it's `README.md`

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22751)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2019-01-23 03:05:21 -05:00 • committed by GitHub
commit 3fe203b7d9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
README.md
View file

@ -216,7 +216,7 @@ pip install virtualenv
``` ```
If this does not work, you may need to reboot for the changed PATH settings (by the python installer) to take effect. If this does not work, you may need to reboot for the changed PATH settings (by the python installer) to take effect.
3. Install the most recent [GStreamer](https://gstreamer.freedesktop.org/data/pkg/windows/) development package following [these instructions](https://github.com/sdroege/gstreamer-rs#gstreamer-binaries-1). You will also need to add `C:\gstreamer\1.0\x86_64\bin` to your `LIB` environment variable. 3. Install the most recent [GStreamer](https://gstreamer.freedesktop.org/data/pkg/windows/) development package following [these instructions](https://github.com/sdroege/gstreamer-rs#gstreamer-binaries-1). You will also need to add `C:\gstreamer\1.0\x86_64\lib` to your `LIB` environment variable.
4. Install Git for Windows (https://git-scm.com/download/win). DO allow it to add git.exe to the PATH (default 4. Install Git for Windows (https://git-scm.com/download/win). DO allow it to add git.exe to the PATH (default
settings for the installer are fine). settings for the installer are fine).