mirror of
https://github.com/servo/servo.git
synced 2025-07-15 19:33:46 +01:00
canvas: Make OffscreenCanvas transferable (without placeholder) (#37872)
Follow the specification and make OffscreenCanvas objects are transferable, but not in case if there are a weak reference to placeholder canvas element. To handle it properly need to implement dedicated frame provider/dispatcher between canvas element (script thread) and offscreen canvas (dedicated worker thread). https://html.spec.whatwg.org/multipage/#the-offscreencanvas-interface:transferable-objects Testing: Improvements in the following tests - html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.detachedcanvas.html - html/canvas/offscreen/manual/convert-to-blob/offscreencanvas.convert.to.blob* - html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transfer* - html/infrastructure/safe-passing-of-structured-data/transfer-errors.window.js Part of #24276 Signed-off-by: Andrei Volykhin <andrei.volykhin@gmail.com>
This commit is contained in:
parent
c3f441d7ab
commit
4054f9a5a0
17 changed files with 159 additions and 60 deletions
|
@ -258,6 +258,7 @@ pub(crate) enum OffscreenRenderingContext {
|
|||
//WebGL2(Dom<WebGL2RenderingContext>),
|
||||
//#[cfg(feature = "webgpu")]
|
||||
//WebGPU(Dom<GPUCanvasContext>),
|
||||
Detached,
|
||||
}
|
||||
|
||||
impl CanvasContext for OffscreenRenderingContext {
|
||||
|
@ -268,54 +269,63 @@ impl CanvasContext for OffscreenRenderingContext {
|
|||
fn canvas(&self) -> Option<HTMLCanvasElementOrOffscreenCanvas> {
|
||||
match self {
|
||||
OffscreenRenderingContext::Context2d(context) => context.canvas(),
|
||||
OffscreenRenderingContext::Detached => None,
|
||||
}
|
||||
}
|
||||
|
||||
fn resize(&self) {
|
||||
match self {
|
||||
OffscreenRenderingContext::Context2d(context) => context.resize(),
|
||||
OffscreenRenderingContext::Detached => {},
|
||||
}
|
||||
}
|
||||
|
||||
fn reset_bitmap(&self) {
|
||||
match self {
|
||||
OffscreenRenderingContext::Context2d(context) => context.reset_bitmap(),
|
||||
OffscreenRenderingContext::Detached => {},
|
||||
}
|
||||
}
|
||||
|
||||
fn get_image_data(&self) -> Option<Snapshot> {
|
||||
match self {
|
||||
OffscreenRenderingContext::Context2d(context) => context.get_image_data(),
|
||||
OffscreenRenderingContext::Detached => None,
|
||||
}
|
||||
}
|
||||
|
||||
fn origin_is_clean(&self) -> bool {
|
||||
match self {
|
||||
OffscreenRenderingContext::Context2d(context) => context.origin_is_clean(),
|
||||
OffscreenRenderingContext::Detached => true,
|
||||
}
|
||||
}
|
||||
|
||||
fn size(&self) -> Size2D<u32> {
|
||||
match self {
|
||||
OffscreenRenderingContext::Context2d(context) => context.size(),
|
||||
OffscreenRenderingContext::Detached => Size2D::default(),
|
||||
}
|
||||
}
|
||||
|
||||
fn mark_as_dirty(&self) {
|
||||
match self {
|
||||
OffscreenRenderingContext::Context2d(context) => context.mark_as_dirty(),
|
||||
OffscreenRenderingContext::Detached => {},
|
||||
}
|
||||
}
|
||||
|
||||
fn update_rendering(&self) {
|
||||
match self {
|
||||
OffscreenRenderingContext::Context2d(context) => context.update_rendering(),
|
||||
OffscreenRenderingContext::Detached => {},
|
||||
}
|
||||
}
|
||||
|
||||
fn onscreen(&self) -> bool {
|
||||
match self {
|
||||
OffscreenRenderingContext::Context2d(context) => context.onscreen(),
|
||||
OffscreenRenderingContext::Detached => false,
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue