Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 07:13:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

More accurate names for .started and .stopped

Browse source
This commit is contained in:
Manish Goregaokar 2018-10-11 13:09:52 -07:00
parent afb824e09c
commit 40641ac8a4
2 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/audiobuffersourcenode.rs
View file

@ -137,7 +137,7 @@ impl AudioBufferSourceNodeMethods for AudioBufferSourceNode {
self.buffer.set(new_buffer); self.buffer.set(new_buffer);
// Step 5. // Step 5.
if self.source_node.started() { if self.source_node.has_start() {
if let Some(buffer) = self.buffer.get() { if let Some(buffer) = self.buffer.get() {
let buffer = buffer.get_channels(); let buffer = buffer.get_channels();
if buffer.is_some() { if buffer.is_some() {

20
components/script/dom/audioscheduledsourcenode.rs
View file

@ -18,8 +18,8 @@ use task_source::{TaskSource, TaskSourceName};
#[dom_struct] #[dom_struct]
pub struct AudioScheduledSourceNode { pub struct AudioScheduledSourceNode {
node: AudioNode, node: AudioNode,
started: Cell<bool>, has_start: Cell<bool>,
stopped: Cell<bool>, has_stop: Cell<bool>,
} }
impl AudioScheduledSourceNode { impl AudioScheduledSourceNode {
@ -39,8 +39,8 @@ impl AudioScheduledSourceNode {
number_of_inputs, number_of_inputs,
number_of_outputs, number_of_outputs,
)?, )?,
started: Cell::new(false), has_start: Cell::new(false),
stopped: Cell::new(false), has_stop: Cell::new(false),
}) })
} }
@ -48,8 +48,8 @@ impl AudioScheduledSourceNode {
&self.node &self.node
} }
pub fn started(&self) -> bool { pub fn has_start(&self) -> bool {
self.started.get() self.has_start.get()
} }
} }
@ -63,7 +63,7 @@ impl AudioScheduledSourceNodeMethods for AudioScheduledSourceNode {
return Err(Error::Range("'when' must be a positive value".to_owned())); return Err(Error::Range("'when' must be a positive value".to_owned()));
} }
if self.started.get() || self.stopped.get() { if self.has_start.get() || self.has_stop.get() {
return Err(Error::InvalidState); return Err(Error::InvalidState);
} }
@ -93,7 +93,7 @@ impl AudioScheduledSourceNodeMethods for AudioScheduledSourceNode {
AudioScheduledSourceNodeMessage::RegisterOnEndedCallback(callback), AudioScheduledSourceNodeMessage::RegisterOnEndedCallback(callback),
)); ));
self.started.set(true); self.has_start.set(true);
self.node self.node
.message(AudioNodeMessage::AudioScheduledSourceNode( .message(AudioNodeMessage::AudioScheduledSourceNode(
AudioScheduledSourceNodeMessage::Start(*when), AudioScheduledSourceNodeMessage::Start(*when),
@ -107,10 +107,10 @@ impl AudioScheduledSourceNodeMethods for AudioScheduledSourceNode {
return Err(Error::Range("'when' must be a positive value".to_owned())); return Err(Error::Range("'when' must be a positive value".to_owned()));
} }
if !self.started.get() { if !self.has_start.get() {
return Err(Error::InvalidState); return Err(Error::InvalidState);
} }
self.stopped.set(true); self.has_stop.set(true);
self.node self.node
.message(AudioNodeMessage::AudioScheduledSourceNode( .message(AudioNodeMessage::AudioScheduledSourceNode(
AudioScheduledSourceNodeMessage::Stop(*when), AudioScheduledSourceNodeMessage::Stop(*when),