Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-01 10:38:25 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #29711 - switchpiggy:sp3, r=mrobinson

Browse source 
Implemented special cases for Element.clientWidth() and clientHeight()

<!-- Please describe your changes on the following line: -->
Implemented the special cases for Element.clientWidth() and Element.clientHeight() as outlined in issue #29704.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] These changes do not require tests because tests already exist.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

[Specification text](https://w3c.github.io/csswg-drafts/cssom-view/#dom-element-clientwidth):
> If the element is the [root element](https://w3c.github.io/csswg-drafts/css-display-4/#root-element) and the element’s [node document](https://dom.spec.whatwg.org/#concept-node-document) is not in [quirks mode](https://dom.spec.whatwg.org/#concept-document-quirks), or if the element is [the body element](https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2) and the element’s node document is in quirks mode, return the [viewport](https://www.w3.org/TR/CSS21/visuren.html#x1) width excluding the size of a rendered scroll bar (if any).
This commit is contained in:
bors-servo 2023-05-08 13:56:51 +02:00 • committed by GitHub
commit 419c03182f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 20 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/wpt/metadata-layout-2020/css/cssom-view/client-props-root.html.ini
View file

@ -1,4 +0,0 @@
[client-props-root.html]
[client* properties on the root element]
expected: FAIL

6
tests/wpt/metadata-layout-2020/css/cssom-view/scrolling-quirks-vs-nonquirks.html.ini
View file

@ -2,9 +2,6 @@
[scrollingElement in non-quirks mode]
expected: FAIL
[clientWidth/clientHeight on the HTML body element in quirks mode]
expected: FAIL
[scrollLeft/scrollRight of the content in quirks mode]
expected: FAIL
@ -14,9 +11,6 @@
[scrollingElement in quirks mode]
expected: FAIL
[clientWidth/clientHeight on the root element in non-quirks mode]
expected: FAIL
[scrollWidth/scrollHeight on the root element in quirks mode]
expected: FAIL

4
tests/wpt/metadata/css/cssom-view/client-props-root.html.ini
View file

@ -1,4 +0,0 @@
[client-props-root.html]
[client* properties on the root element]
expected: FAIL

6
tests/wpt/metadata/css/cssom-view/scrolling-quirks-vs-nonquirks.html.ini
View file

@ -8,9 +8,6 @@
[scrollWidth/scrollHeight on the HTML body element in quirks mode]
expected: FAIL
[clientWidth/clientHeight on the HTML body element in quirks mode]
expected: FAIL
[scrollLeft/scrollRight of the content in quirks mode]
expected: FAIL
@ -20,9 +17,6 @@
[scrollWidth/scrollHeight on the root element in non-quirks mode]
expected: FAIL
[clientWidth/clientHeight on the root element in non-quirks mode]
expected: FAIL
[scroll() on the HTML body element in non-quirks mode]
expected: FAIL