mirror of
https://github.com/servo/servo.git
synced 2025-06-04 07:35:36 +00:00
Rename Stylesheet::Type_
to Stylesheet::Type
(#37126)
I'm not sure if `CodegenRust.py` was supposed to remove the underscore, but we end up exposing `type_` to javascript which is obviously wrong. There's no need to rename the method in the first place, because `Type` (with a capital T) is not a rust keyword. Testing: Covered by existing web platform tests --------- Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
parent
70a2ea3a66
commit
41ecfb53a1
3 changed files with 3 additions and 9 deletions
|
@ -39,8 +39,8 @@ impl StyleSheet {
|
|||
}
|
||||
|
||||
impl StyleSheetMethods<crate::DomTypeHolder> for StyleSheet {
|
||||
// https://drafts.csswg.org/cssom/#dom-stylesheet-type
|
||||
fn Type_(&self) -> DOMString {
|
||||
/// <https://drafts.csswg.org/cssom/#dom-stylesheet-type>
|
||||
fn Type(&self) -> DOMString {
|
||||
self.type_.clone()
|
||||
}
|
||||
|
||||
|
|
|
@ -5,7 +5,7 @@
|
|||
// https://drafts.csswg.org/cssom/#the-stylesheet-interface
|
||||
[Exposed=Window]
|
||||
interface StyleSheet {
|
||||
readonly attribute DOMString type_;
|
||||
readonly attribute DOMString type;
|
||||
readonly attribute DOMString? href;
|
||||
|
||||
readonly attribute Element? ownerNode;
|
||||
|
|
6
tests/wpt/meta/css/cssom/idlharness.html.ini
vendored
6
tests/wpt/meta/css/cssom/idlharness.html.ini
vendored
|
@ -53,9 +53,6 @@
|
|||
[CSSStyleDeclaration interface: sheet.cssRules[2\].style must inherit property "setProperty(CSSOMString, CSSOMString, optional CSSOMString)" with the proper type]
|
||||
expected: FAIL
|
||||
|
||||
[StyleSheet interface: attribute type]
|
||||
expected: FAIL
|
||||
|
||||
[Stringification of sheet.cssRules[2\].cssRules[0\]]
|
||||
expected: FAIL
|
||||
|
||||
|
@ -254,9 +251,6 @@
|
|||
[CSSStyleDeclaration interface: sheet.cssRules[2\].cssRules[0\].style must inherit property "parentRule" with the proper type]
|
||||
expected: FAIL
|
||||
|
||||
[StyleSheet interface: sheet must inherit property "type" with the proper type]
|
||||
expected: FAIL
|
||||
|
||||
[CSSStyleDeclaration interface: sheet.cssRules[2\].cssRules[0\].style must inherit property "cssText" with the proper type]
|
||||
expected: FAIL
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue