Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 00:25:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

Rename Stylesheet::Type_ to Stylesheet::Type (#37126)

Browse source 
I'm not sure if `CodegenRust.py` was supposed to remove the underscore,
but we end up exposing `type_` to javascript which is obviously wrong.
There's no need to rename the method in the first place, because `Type`
(with a capital T) is not a rust keyword.

Testing: Covered by existing web platform tests

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
Simon Wülker 2025-05-25 19:36:16 +02:00 • committed by GitHub
parent 70a2ea3a66
commit 41ecfb53a1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 3 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/script/dom/stylesheet.rs
View file

@ -39,8 +39,8 @@ impl StyleSheet {
} }
impl StyleSheetMethods<crate::DomTypeHolder> for StyleSheet { impl StyleSheetMethods<crate::DomTypeHolder> for StyleSheet {
// https://drafts.csswg.org/cssom/#dom-stylesheet-type /// <https://drafts.csswg.org/cssom/#dom-stylesheet-type>
fn Type_(&self) -> DOMString { fn Type(&self) -> DOMString {
self.type_.clone() self.type_.clone()
} }

2
components/script_bindings/webidls/StyleSheet.webidl
View file

@ -5,7 +5,7 @@
// https://drafts.csswg.org/cssom/#the-stylesheet-interface // https://drafts.csswg.org/cssom/#the-stylesheet-interface
[Exposed=Window] [Exposed=Window]
interface StyleSheet { interface StyleSheet {
readonly attribute DOMString type_; readonly attribute DOMString type;
readonly attribute DOMString? href; readonly attribute DOMString? href;
readonly attribute Element? ownerNode; readonly attribute Element? ownerNode;

6
tests/wpt/meta/css/cssom/idlharness.html.ini vendored
View file

@ -53,9 +53,6 @@
[CSSStyleDeclaration interface: sheet.cssRules[2\].style must inherit property "setProperty(CSSOMString, CSSOMString, optional CSSOMString)" with the proper type] [CSSStyleDeclaration interface: sheet.cssRules[2\].style must inherit property "setProperty(CSSOMString, CSSOMString, optional CSSOMString)" with the proper type]
expected: FAIL expected: FAIL
[StyleSheet interface: attribute type]
expected: FAIL
[Stringification of sheet.cssRules[2\].cssRules[0\]] [Stringification of sheet.cssRules[2\].cssRules[0\]]
expected: FAIL expected: FAIL
@ -254,9 +251,6 @@
[CSSStyleDeclaration interface: sheet.cssRules[2\].cssRules[0\].style must inherit property "parentRule" with the proper type] [CSSStyleDeclaration interface: sheet.cssRules[2\].cssRules[0\].style must inherit property "parentRule" with the proper type]
expected: FAIL expected: FAIL
[StyleSheet interface: sheet must inherit property "type" with the proper type]
expected: FAIL
[CSSStyleDeclaration interface: sheet.cssRules[2\].cssRules[0\].style must inherit property "cssText" with the proper type] [CSSStyleDeclaration interface: sheet.cssRules[2\].cssRules[0\].style must inherit property "cssText" with the proper type]
expected: FAIL expected: FAIL