From 4279fe5933da5f3e70bbddc152c444dbbc517d13 Mon Sep 17 00:00:00 2001 From: Anthony Ramine Date: Sun, 29 Mar 2020 19:54:53 +0200 Subject: [PATCH] Fix LayoutElementHelpers::get_classes_for_layout It should not return a 'static reference --- components/script/dom/element.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/script/dom/element.rs b/components/script/dom/element.rs index 1521207faee..b1472fd6791 100644 --- a/components/script/dom/element.rs +++ b/components/script/dom/element.rs @@ -624,7 +624,7 @@ pub trait LayoutElementHelpers<'dom> { #[allow(unsafe_code)] unsafe fn has_class_for_layout(self, name: &Atom, case_sensitivity: CaseSensitivity) -> bool; #[allow(unsafe_code)] - unsafe fn get_classes_for_layout(self) -> Option<&'static [Atom]>; + unsafe fn get_classes_for_layout(self) -> Option<&'dom [Atom]>; #[allow(unsafe_code)] unsafe fn synthesize_presentational_hints_for_legacy_attributes(self, _: &mut V) @@ -666,7 +666,7 @@ impl<'dom> LayoutElementHelpers<'dom> for LayoutDom<'dom, Element> { #[allow(unsafe_code)] #[inline] - unsafe fn get_classes_for_layout(self) -> Option<&'static [Atom]> { + unsafe fn get_classes_for_layout(self) -> Option<&'dom [Atom]> { get_attr_for_layout(&*self.unsafe_get(), &ns!(), &local_name!("class")) .map(|attr| attr.value_tokens_forever().unwrap()) }