From 42c705b4adf92c79156247228905db9135de39f1 Mon Sep 17 00:00:00 2001 From: Li-Hsuan Hsieh Date: Sat, 26 Aug 2023 02:28:51 +0800 Subject: [PATCH] Fix type attribute for module script not in case insensitive issue (#30206) * fix(htmlscriptelement): Make sure type for module is in case insensitive * fix(htmlscripthtml): Remove related .ini file since the tests are passed --- components/script/dom/htmlscriptelement.rs | 4 +++- .../scripting-1/the-script-element/module/type.html.ini | 7 ------- .../scripting-1/the-script-element/module/type.html.ini | 7 ------- 3 files changed, 3 insertions(+), 15 deletions(-) delete mode 100644 tests/wpt/meta-legacy-layout/html/semantics/scripting-1/the-script-element/module/type.html.ini delete mode 100644 tests/wpt/meta/html/semantics/scripting-1/the-script-element/module/type.html.ini diff --git a/components/script/dom/htmlscriptelement.rs b/components/script/dom/htmlscriptelement.rs index 8889f6ad696..dfadc364ded 100644 --- a/components/script/dom/htmlscriptelement.rs +++ b/components/script/dom/htmlscriptelement.rs @@ -1186,7 +1186,9 @@ impl HTMLScriptElement { (Some(ref ty), _) => { debug!("script type={}", &***ty); - if &***ty == String::from("module") { + if ty.to_ascii_lowercase().trim_matches(HTML_SPACE_CHARACTERS) == + String::from("module") + { return Some(ScriptType::Module); } diff --git a/tests/wpt/meta-legacy-layout/html/semantics/scripting-1/the-script-element/module/type.html.ini b/tests/wpt/meta-legacy-layout/html/semantics/scripting-1/the-script-element/module/type.html.ini deleted file mode 100644 index 580daddd58a..00000000000 --- a/tests/wpt/meta-legacy-layout/html/semantics/scripting-1/the-script-element/module/type.html.ini +++ /dev/null @@ -1,7 +0,0 @@ -[type.html] - [type="MODULE"] - expected: FAIL - - [type="Module"] - expected: FAIL - diff --git a/tests/wpt/meta/html/semantics/scripting-1/the-script-element/module/type.html.ini b/tests/wpt/meta/html/semantics/scripting-1/the-script-element/module/type.html.ini deleted file mode 100644 index 580daddd58a..00000000000 --- a/tests/wpt/meta/html/semantics/scripting-1/the-script-element/module/type.html.ini +++ /dev/null @@ -1,7 +0,0 @@ -[type.html] - [type="MODULE"] - expected: FAIL - - [type="Module"] - expected: FAIL -