mirror of
https://github.com/servo/servo.git
synced 2025-07-24 15:50:21 +01:00
Avoid marking codegen method bodies as unsafe twice
`CGAbstractMethod` takes a couple boolean parameters, among others: * `extern`: will mark the method as `unsafe` and `extern` * `unsafe`: will wrap the method body in an `unsafe` block Passing both as `True` should not mark it as `unsafe` twice. Example from a generated `HTMLCollectionBinding.rs`: Before: ``` unsafe extern fn get_length(..) -> u8 { unsafe { // code here } } ``` After ``` unsafe extern fn get_length(..) -> u8 { // code here } ```
This commit is contained in:
parent
1542a879a5
commit
43429abce4
1 changed files with 3 additions and 1 deletions
|
@ -2089,7 +2089,9 @@ class CGAbstractMethod(CGThing):
|
|||
|
||||
def define(self):
|
||||
body = self.definition_body()
|
||||
if self.unsafe:
|
||||
|
||||
# Method will already be marked `unsafe` if `self.extern == True`
|
||||
if self.unsafe and not self.extern:
|
||||
body = CGWrapper(CGIndenter(body), pre="unsafe {\n", post="\n}")
|
||||
|
||||
return CGWrapper(CGIndenter(body),
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue