Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #25359 - pshaughn:auto_ct_header, r=jdm

Browse source 
Autocomputed content-type header now reaches net request

The spec expects that for a DOM Request r, r.headers and r.request can actually refer to the same header list in RAM, with changes to one affecting the other. This is mostly unobservable, but it happens to come up at the point in the Request constructor that auto-infers a content type from the body, so now after inferring the content type it injects it into both header lists instead of one.
Remaining test failures are due to the way Hyper crates normalize semicolons in MIME types, and an actually separate problem about content-lengths that I haven't sniffed out yet.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix some WPT results from #24904

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
bors-servo 2019-12-22 11:12:56 -05:00 • committed by GitHub
commit 43a5f65940
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

31
tests/wpt/metadata/fetch/api/basic/request-headers.any.js.ini
View file

@ -1,47 +1,16 @@
[request-headers.any.html]
type: testharness
[Fetch with PUT with body]
expected: FAIL
[Fetch with POST with text body]
expected: FAIL
[Fetch with POST with FormData body]
expected: FAIL
[Fetch with POST with URLSearchParams body]
expected: FAIL
[Fetch with POST with Blob body with mime type]
expected: FAIL
[Fetch with Chicken]
expected: FAIL
[Fetch with Chicken with body]
expected: FAIL
[request-headers.any.worker.html]
type: testharness
[Fetch with PUT with body]
expected: FAIL
[Fetch with POST with text body]
expected: FAIL
[Fetch with POST with FormData body]
expected: FAIL
[Fetch with POST with URLSearchParams body]
expected: FAIL
[Fetch with POST with Blob body with mime type]
expected: FAIL
[Fetch with Chicken]
expected: FAIL
[Fetch with Chicken with body]
expected: FAIL