Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 13:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implement getter for child BCs correctly

Browse source
This commit is contained in:
Keith Yeung 2018-05-31 16:55:38 -07:00
parent 022daccbe1
commit 43c87db3ca
2 changed files with 4 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/constellation/constellation.rs
View file

@ -1164,10 +1164,10 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>
}
}
FromScriptMsg::GetChildBrowsingContextId(browsing_context_id, index, sender) => {
// We increment here because the 0th element is the parent browsing context itself
let result = self.all_descendant_browsing_contexts_iter(browsing_context_id)
.nth(index + 1)
.map(|bc| bc.id);
let result = self.browsing_contexts.get(&browsing_context_id)
.and_then(|bc| self.pipelines.get(&bc.pipeline_id))
.and_then(|pipeline| pipeline.children.get(index))
.map(|maybe_bcid| *maybe_bcid);
if let Err(e) = sender.send(result) {
warn!("Sending reply to get child browsing context ID failed ({:?}).", e);
}

5
tests/wpt/metadata/html/semantics/forms/resetting-a-form/reset-form-event-realm.html.ini
View file

@ -1,5 +0,0 @@
[reset-form-event-realm.html]
type: testharness
[reset()'s event must be fired in the Realm of the target]
expected: FAIL