Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

clippy: fix warnings in components/shared (#31565)

Browse source 
* clippy: fix some warnings in components/shared

* fix: unit tests

* fix: review comments
This commit is contained in:
eri 2024-03-08 16:28:19 +01:00 • committed by GitHub
parent 3a5ca785d3
commit 43f44965cd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
14 changed files with 102 additions and 139 deletions
Download patch file Download diff file Expand all files Collapse all files

16
components/shared/net/response.rs
View file

@ -189,10 +189,7 @@ impl Response {
}
pub fn is_network_error(&self) -> bool {
match self.response_type {
ResponseType::Error(..) => true,
_ => false,
}
matches!(self.response_type, ResponseType::Error(..))
}
pub fn get_network_error(&self) -> Option<&NetworkError> {
@ -204,7 +201,7 @@ impl Response {
pub fn actual_response(&self) -> &Response {
if self.return_internal && self.internal_response.is_some() {
&**self.internal_response.as_ref().unwrap()
self.internal_response.as_ref().unwrap()
} else {
self
}
@ -212,7 +209,7 @@ impl Response {
pub fn actual_response_mut(&mut self) -> &mut Response {
if self.return_internal && self.internal_response.is_some() {
&mut **self.internal_response.as_mut().unwrap()
self.internal_response.as_mut().unwrap()
} else {
self
}
@ -258,10 +255,7 @@ impl Response {
ResponseType::Basic => {
let headers = old_headers.iter().filter(|(name, _)| {
match &*name.as_str().to_ascii_lowercase() {
"set-cookie" | "set-cookie2" => false,
_ => true
}
!matches!(&*name.as_str().to_ascii_lowercase(), "set-cookie" | "set-cookie2")
}).map(|(n, v)| (n.clone(), v.clone())).collect();
response.headers = headers;
},
@ -315,7 +309,7 @@ impl Response {
metadata.status = response.raw_status.clone();
metadata.https_state = response.https_state;
metadata.referrer = response.referrer.clone();
metadata.referrer_policy = response.referrer_policy.clone();
metadata.referrer_policy = response.referrer_policy;
metadata.redirected = response.actual_response().url_list.len() > 1;
metadata
}