Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 13:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix column numbering in getBreakpointPositionsCompressed handler

Browse source 
Co-authored-by: atbrakhi <atbrakhi@igalia.com>
Signed-off-by: Delan Azabani <dazabani@igalia.com>
This commit is contained in:
Delan Azabani 2025-06-24 20:06:22 +10:00
parent 8381b5a6d6
commit 4564a4a18a
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
components/devtools/actors/source.rs
View file

@ -192,11 +192,12 @@ impl Actor for SourceActor {
let mut positions = BTreeMap::default(); let mut positions = BTreeMap::default();
if let Some(content) = self.content.as_ref() { if let Some(content) = self.content.as_ref() {
for (line_number, line) in content.lines().enumerate() { for (line_number, line) in content.lines().enumerate() {
// Column numbers are in Unicode scalar values, not UTF-16 code units or grapheme clusters. // Column numbers are in UTF-16 code units, not Unicode scalar values or grapheme clusters.
let column_count = line.chars().count(); let column_count = line.encode_utf16().count();
// Line and column numbers are one-based. // Line number are one-based. Column numbers are zero-based.
// FIXME: the docs say column numbers are one-based, but this appears to be incorrect.
// <https://firefox-source-docs.mozilla.org/devtools/backend/protocol.html#source-locations> // <https://firefox-source-docs.mozilla.org/devtools/backend/protocol.html#source-locations>
positions.insert(line_number + 1, (1..=column_count).collect()); positions.insert(line_number + 1, (0..column_count).collect());
} }
} }
let reply = GetBreakpointPositionsCompressedReply { let reply = GetBreakpointPositionsCompressedReply {