Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-27 07:10:19 +01:00
Code Issues Projects Releases Packages Wiki Activity

Add abort signal preference to experimental web features (#39421)

Browse source 
This way we have full coverage on WPT rather than the
specific folders with tests.

Part of #34866

Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
This commit is contained in:
Tim van der Lippe 2025-09-26 16:41:53 +02:00 • committed by GitHub
parent 4886d1e39c
commit 461c2427f3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
46 changed files with 58 additions and 288 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tests/wpt/meta/IndexedDB/back-forward-cache-open-connection.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[back-forward-cache-open-connection.window.html]
expected: TIMEOUT
[Testing BFCache support for page with open IndexedDB connection, and eviction behavior when receiving versionchange event.]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/IndexedDB/back-forward-cache-open-transaction.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[back-forward-cache-open-transaction.window.html]
expected: TIMEOUT
[BFCache support test for page with open IndexedDB transaction]
expected: FAIL
expected: TIMEOUT

2
tests/wpt/meta/credential-management/credentialscontainer-get-basics.https.html.ini vendored
View file

@ -1,6 +1,4 @@
[credentialscontainer-get-basics.https.html]
[Calling navigator.credentials.get() without a valid matching interface.]
expected: FAIL
[navigator.credentials.get() aborted with custom reason]
expected: FAIL

3
tests/wpt/meta/dom/abort/__dir__.ini vendored
View file

@ -1,3 +0,0 @@
prefs: [
"dom_abort_controller_enabled:true",
]

3
tests/wpt/meta/dom/events/__dir__.ini vendored
View file

@ -1,3 +0,0 @@
prefs: [
"dom_abort_controller_enabled:true",
]

90
tests/wpt/meta/dom/idlharness.any.js.ini vendored
View file

@ -5,114 +5,24 @@
expected: ERROR
[idlharness.any.worker.html]
[AbortController interface: attribute signal]
expected: FAIL
[AbortController interface: operation abort()]
expected: FAIL
[AbortController interface: new AbortController() must inherit property "signal" with the proper type]
expected: FAIL
[AbortController interface: new AbortController() must inherit property "abort()" with the proper type]
expected: FAIL
[AbortSignal interface: operation abort()]
expected: FAIL
[AbortSignal must be primary interface of new AbortController().signal]
expected: FAIL
[Stringification of new AbortController().signal]
expected: FAIL
[AbortSignal interface: new AbortController().signal must inherit property "abort()" with the proper type]
expected: FAIL
[AbortSignal interface: new AbortController().signal must inherit property "aborted" with the proper type]
expected: FAIL
[AbortSignal interface: new AbortController().signal must inherit property "onabort" with the proper type]
expected: FAIL
[EventTarget interface: new AbortController().signal must inherit property "addEventListener(DOMString, EventListener?, optional (AddEventListenerOptions or boolean))" with the proper type]
expected: FAIL
[EventTarget interface: calling addEventListener(DOMString, EventListener?, optional (AddEventListenerOptions or boolean)) on new AbortController().signal with too few arguments must throw TypeError]
expected: FAIL
[EventTarget interface: new AbortController().signal must inherit property "removeEventListener(DOMString, EventListener?, optional (EventListenerOptions or boolean))" with the proper type]
expected: FAIL
[EventTarget interface: calling removeEventListener(DOMString, EventListener?, optional (EventListenerOptions or boolean)) on new AbortController().signal with too few arguments must throw TypeError]
expected: FAIL
[EventTarget interface: new AbortController().signal must inherit property "dispatchEvent(Event)" with the proper type]
expected: FAIL
[EventTarget interface: calling dispatchEvent(Event) on new AbortController().signal with too few arguments must throw TypeError]
expected: FAIL
[AbortSignal interface: new AbortController().signal must inherit property "abort(optional any)" with the proper type]
expected: FAIL
[AbortSignal interface: calling abort(optional any) on new AbortController().signal with too few arguments must throw TypeError]
expected: FAIL
[AbortSignal interface: new AbortController().signal must inherit property "reason" with the proper type]
expected: FAIL
[AbortSignal interface: new AbortController().signal must inherit property "throwIfAborted()" with the proper type]
expected: FAIL
[AbortSignal interface: operation timeout(unsigned long long)]
expected: FAIL
[AbortSignal interface: new AbortController().signal must inherit property "timeout(unsigned long long)" with the proper type]
expected: FAIL
[AbortSignal interface: calling timeout(unsigned long long) on new AbortController().signal with too few arguments must throw TypeError]
expected: FAIL
[AbortSignal interface: new AbortController().signal must inherit property "any(sequence<AbortSignal>)" with the proper type]
expected: FAIL
[AbortSignal interface: calling any(sequence<AbortSignal>) on new AbortController().signal with too few arguments must throw TypeError]
expected: FAIL
[AbortController interface: existence and properties of interface object]
expected: FAIL
[AbortController interface object length]
expected: FAIL
[AbortController interface object name]
expected: FAIL
[AbortController interface: existence and properties of interface prototype object]
expected: FAIL
[AbortController interface: existence and properties of interface prototype object's "constructor" property]
expected: FAIL
[AbortController interface: existence and properties of interface prototype object's @@unscopables property]
expected: FAIL
[AbortController interface: operation abort(optional any)]
expected: FAIL
[AbortController must be primary interface of new AbortController()]
expected: FAIL
[Stringification of new AbortController()]
expected: FAIL
[AbortController interface: new AbortController() must inherit property "abort(optional any)" with the proper type]
expected: FAIL
[AbortController interface: calling abort(optional any) on new AbortController() with too few arguments must throw TypeError]
expected: FAIL
[idlharness.any.shadowrealm-in-window.html]
expected: ERROR

90
tests/wpt/meta/dom/idlharness.window.js.ini vendored
View file

@ -1,49 +1,13 @@
[idlharness.window.html?exclude=Node]
[AbortSignal must be primary interface of new AbortController().signal]
expected: FAIL
[EventTarget interface: calling removeEventListener(DOMString, EventListener?, optional (EventListenerOptions or boolean)) on new AbortController().signal with too few arguments must throw TypeError]
expected: FAIL
[EventTarget interface: new AbortController().signal must inherit property "addEventListener(DOMString, EventListener?, optional (AddEventListenerOptions or boolean))" with the proper type]
expected: FAIL
[EventTarget interface: new AbortController().signal must inherit property "dispatchEvent(Event)" with the proper type]
expected: FAIL
[EventTarget interface: new AbortController().signal must inherit property "removeEventListener(DOMString, EventListener?, optional (EventListenerOptions or boolean))" with the proper type]
expected: FAIL
[AbortController interface: operation abort()]
expected: FAIL
[AbortController interface: attribute signal]
expected: FAIL
[AbortController interface: new AbortController() must inherit property "signal" with the proper type]
expected: FAIL
[AbortController interface: new AbortController() must inherit property "abort()" with the proper type]
expected: FAIL
[EventTarget interface: calling dispatchEvent(Event) on new AbortController().signal with too few arguments must throw TypeError]
expected: FAIL
[AbortSignal interface: new AbortController().signal must inherit property "aborted" with the proper type]
expected: FAIL
[EventTarget interface: calling addEventListener(DOMString, EventListener?, optional (AddEventListenerOptions or boolean)) on new AbortController().signal with too few arguments must throw TypeError]
expected: FAIL
[AbortSignal interface: new AbortController().signal must inherit property "onabort" with the proper type]
expected: FAIL
[NodeFilter interface: existence and properties of interface object]
expected: FAIL
[Stringification of new AbortController().signal]
expected: FAIL
[XPathNSResolver interface: document.createNSResolver(document.body) must inherit property "lookupNamespaceURI(DOMString?)" with the proper type]
expected: FAIL
@ -149,24 +113,9 @@
[XSLTProcessor interface: new XSLTProcessor() must inherit property "reset()" with the proper type]
expected: FAIL
[AbortSignal interface: new AbortController().signal must inherit property "abort(optional any)" with the proper type]
expected: FAIL
[AbortSignal interface: calling abort(optional any) on new AbortController().signal with too few arguments must throw TypeError]
expected: FAIL
[AbortSignal interface: new AbortController().signal must inherit property "reason" with the proper type]
expected: FAIL
[AbortSignal interface: new AbortController().signal must inherit property "throwIfAborted()" with the proper type]
expected: FAIL
[AbortSignal interface: operation timeout(unsigned long long)]
expected: FAIL
[AbortSignal interface: new AbortController().signal must inherit property "timeout(unsigned long long)" with the proper type]
expected: FAIL
[AbortSignal interface: calling timeout(unsigned long long) on new AbortController().signal with too few arguments must throw TypeError]
expected: FAIL
@ -194,12 +143,6 @@
[Element interface: element must inherit property "onfullscreenerror" with the proper type]
expected: FAIL
[AbortSignal interface: new AbortController().signal must inherit property "any(sequence<AbortSignal>)" with the proper type]
expected: FAIL
[AbortSignal interface: calling any(sequence<AbortSignal>) on new AbortController().signal with too few arguments must throw TypeError]
expected: FAIL
[Document interface: operation prepend((Node or TrustedScript or DOMString)...)]
expected: FAIL
@ -254,39 +197,6 @@
[CharacterData interface: operation replaceWith((Node or TrustedScript or DOMString)...)]
expected: FAIL
[AbortController interface: existence and properties of interface object]
expected: FAIL
[AbortController interface object length]
expected: FAIL
[AbortController interface object name]
expected: FAIL
[AbortController interface: existence and properties of interface prototype object]
expected: FAIL
[AbortController interface: existence and properties of interface prototype object's "constructor" property]
expected: FAIL
[AbortController interface: existence and properties of interface prototype object's @@unscopables property]
expected: FAIL
[AbortController interface: operation abort(optional any)]
expected: FAIL
[AbortController must be primary interface of new AbortController()]
expected: FAIL
[Stringification of new AbortController()]
expected: FAIL
[AbortController interface: new AbortController() must inherit property "abort(optional any)" with the proper type]
expected: FAIL
[AbortController interface: calling abort(optional any) on new AbortController() with too few arguments must throw TypeError]
expected: FAIL
[Document interface: operation moveBefore(Node, Node?)]
expected: FAIL

6
tests/wpt/meta/dom/interface-objects.html.ini vendored
View file

@ -1,6 +0,0 @@
[interface-objects.html]
[Should be able to delete AbortSignal.]
expected: FAIL
[Should be able to delete AbortController.]
expected: FAIL

3
tests/wpt/meta/fetch/api/abort/__dir__.ini vendored
View file

@ -1,3 +0,0 @@
prefs: [
"dom_abort_controller_enabled:true",
]

1
tests/wpt/meta/fetch/fetch-later/quota/cross-origin-iframe/multiple-iframes.https.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[multiple-iframes.https.window.html]
expected: ERROR
[fetchLater() request quota are delegated to cross-origin iframes and not shared, even if they are same origin.]
expected: FAIL

3
tests/wpt/meta/fetch/fetch-later/send-on-deactivate.https.window.js.ini vendored
View file

@ -1,9 +1,10 @@
[send-on-deactivate.https.window.html]
expected: TIMEOUT
[fetchLater() sends on page entering BFCache if BackgroundSync is off.]
expected: FAIL
[Call fetchLater() when BFCached with activateAfter=0 sends immediately.]
expected: FAIL
expected: TIMEOUT
[fetchLater() sends on navigating away a page w/o BFCache.]
expected: FAIL

3
tests/wpt/meta/html/browsers/browsing-the-web/back-forward-cache/broadcastchannel/broadcastchannel.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[broadcastchannel.window.html]
expected: TIMEOUT
[Ensure that open broadcastchannel does not block bfcache.]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/html/browsers/browsing-the-web/back-forward-cache/broadcastchannel/dedicatedworker.tentative.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[dedicatedworker.tentative.window.html]
expected: TIMEOUT
[BroadcastChannel messages dispatched to dedicated worker in bfcache should be queued.]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/html/browsers/browsing-the-web/back-forward-cache/broadcastchannel/evict-on-message.tentative.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[evict-on-message.tentative.window.html]
expected: TIMEOUT
[BroadcastChannel message while in bfcache should evict the entry.]
expected: FAIL
expected: TIMEOUT

5
tests/wpt/meta/html/browsers/browsing-the-web/history-traversal/document-state.https.html.ini vendored
View file

@ -1,6 +1,7 @@
[document-state.https.html]
expected: TIMEOUT
[A navigation's initiator origin and referrer are stored in the document state and used in the document repopulation case]
expected: FAIL
expected: TIMEOUT
[A navigation's initiator origin and referrer are stored in the document state and used on location.reload()]
expected: FAIL
expected: NOTRUN

3
tests/wpt/meta/html/browsers/browsing-the-web/remote-context-helper-tests/navigateToNew.window.js.ini vendored
View file

@ -1,3 +0,0 @@
[navigateToNew.window.html]
[RemoteContextWrapper navigateToNew]
expected: FAIL

3
tests/wpt/meta/html/browsers/browsing-the-web/remote-context-helper-tests/navigation-bfcache.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[navigation-bfcache.window.html]
expected: TIMEOUT
[RemoteContextHelper navigation using BFCache]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/html/browsers/browsing-the-web/remote-context-helper-tests/navigation-helpers.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[navigation-helpers.window.html]
expected: TIMEOUT
[RemoteContextHelper navigation helpers]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/html/browsers/browsing-the-web/remote-context-helper-tests/navigation-same-document.window.js.ini vendored
View file

@ -1,3 +0,0 @@
[navigation-same-document.window.html]
[RemoteContextHelper navigation using BFCache]
expected: FAIL

3
tests/wpt/meta/html/browsers/browsing-the-web/unloading-documents/unload/unload-main-frame-cross-origin.window.js.ini vendored
View file

@ -1,3 +0,0 @@
[unload-main-frame-cross-origin.window.html]
[Unload runs in main frame when navigating cross-origin.]
expected: FAIL

3
tests/wpt/meta/html/browsers/browsing-the-web/unloading-documents/unload/unload-main-frame-same-origin.window.js.ini vendored
View file

@ -1,3 +0,0 @@
[unload-main-frame-same-origin.window.html]
[Unload runs in main frame when navigating same-origin.]
expected: FAIL

3
tests/wpt/meta/html/browsers/history/the-history-interface/history-state-after-bfcache.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[history-state-after-bfcache.window.html]
expected: TIMEOUT
[Navigating back to a bfcached page does not reset history.state]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/html/browsers/windows/auxiliary-browsing-contexts/no-proactive-swap-when-other-contexts-in-group.html.ini vendored
View file

@ -1,3 +0,0 @@
[no-proactive-swap-when-other-contexts-in-group.html]
[no proactive browsing context group change when other contexts in group]
expected: FAIL

6
tests/wpt/meta/html/semantics/links/links-created-by-a-and-area-elements/rel-opener-prevents-browsing-context-group-change.tentative.html.ini vendored
View file

@ -1,6 +0,0 @@
[rel-opener-prevents-browsing-context-group-change.tentative.html]
[rel=opener prevents browsing context group change]
expected: FAIL
[opener window feature prevents browsing context group change]
expected: FAIL

3
tests/wpt/meta/performance-timeline/not-restored-reasons/performance-navigation-timing-attributes.tentative.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[performance-navigation-timing-attributes.tentative.window.html]
expected: TIMEOUT
[RemoteContextHelper navigation using BFCache]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/performance-timeline/not-restored-reasons/performance-navigation-timing-bfcache-reasons-stay.tentative.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[performance-navigation-timing-bfcache-reasons-stay.tentative.window.html]
expected: TIMEOUT
[RemoteContextHelper navigation using BFCache]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/performance-timeline/not-restored-reasons/performance-navigation-timing-bfcache.tentative.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[performance-navigation-timing-bfcache.tentative.window.html]
expected: TIMEOUT
[RemoteContextHelper navigation using BFCache]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/performance-timeline/not-restored-reasons/performance-navigation-timing-cross-origin-bfcache.tentative.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[performance-navigation-timing-cross-origin-bfcache.tentative.window.html]
expected: TIMEOUT
[RemoteContextHelper navigation using BFCache]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/performance-timeline/not-restored-reasons/performance-navigation-timing-fetch.tentative.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[performance-navigation-timing-fetch.tentative.window.html]
expected: TIMEOUT
[Ensure that ongoing fetch upon entering bfcache blocks bfcache and recorded.]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/performance-timeline/not-restored-reasons/performance-navigation-timing-navigation-failure.tentative.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[performance-navigation-timing-navigation-failure.tentative.window.html]
expected: TIMEOUT
[Ensure that navigation failure blocks bfcache and gets recorded.]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/performance-timeline/not-restored-reasons/performance-navigation-timing-not-bfcached.tentative.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[performance-navigation-timing-not-bfcached.tentative.window.html]
expected: TIMEOUT
[RemoteContextHelper navigation using BFCache]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/performance-timeline/not-restored-reasons/performance-navigation-timing-redirect-on-history.tentative.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[performance-navigation-timing-redirect-on-history.tentative.window.html]
expected: TIMEOUT
[RemoteContextHelper navigation using BFCache]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/performance-timeline/not-restored-reasons/performance-navigation-timing-reload.tentative.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[performance-navigation-timing-reload.tentative.window.html]
expected: TIMEOUT
[RemoteContextHelper navigation using BFCache]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/performance-timeline/not-restored-reasons/performance-navigation-timing-same-origin-bfcache.tentative.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[performance-navigation-timing-same-origin-bfcache.tentative.window.html]
expected: TIMEOUT
[RemoteContextHelper navigation using BFCache]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/streams/__dir__.ini vendored
View file

@ -1,3 +0,0 @@
prefs: [
"dom_abort_controller_enabled:true",
]

1
tests/wpt/meta/streams/piping/abort.any.js.ini vendored
View file

@ -1,4 +1,3 @@
prefs: [dom_abort_controller_enabled:true]
[abort.https.any.shadowrealm-in-serviceworker.html]
expected: ERROR

38
tests/wpt/meta/wasm/webapi/abort.any.js.ini vendored
View file

@ -1,38 +0,0 @@
[abort.any.html]
[compileStreaming() on an already-aborted request should reject with AbortError]
expected: FAIL
[compileStreaming() synchronously followed by abort should reject with AbortError]
expected: FAIL
[instantiateStreaming() on an already-aborted request should reject with AbortError]
expected: FAIL
[instantiateStreaming() synchronously followed by abort should reject with AbortError]
expected: FAIL
[compileStreaming() asynchronously racing with abort should succeed or reject with AbortError]
expected: FAIL
[instantiateStreaming() asynchronously racing with abort should succeed or reject with AbortError]
expected: FAIL
[abort.any.worker.html]
[compileStreaming() on an already-aborted request should reject with AbortError]
expected: FAIL
[compileStreaming() synchronously followed by abort should reject with AbortError]
expected: FAIL
[instantiateStreaming() on an already-aborted request should reject with AbortError]
expected: FAIL
[instantiateStreaming() synchronously followed by abort should reject with AbortError]
expected: FAIL
[compileStreaming() asynchronously racing with abort should succeed or reject with AbortError]
expected: FAIL
[instantiateStreaming() asynchronously racing with abort should succeed or reject with AbortError]
expected: FAIL

2
tests/wpt/meta/webmessaging/message-channels/close-event/document-destroyed.tentative.window.js.ini vendored
View file

@ -1,5 +1,5 @@
[document-destroyed.tentative.window.html]
expected: ERROR
expected: TIMEOUT
[The context is navigated to a new document and a close event is fired.]
expected: TIMEOUT

3
tests/wpt/meta/websockets/back-forward-cache-with-closed-websocket-connection-ccns.tentative.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[back-forward-cache-with-closed-websocket-connection-ccns.tentative.window.html]
expected: TIMEOUT
[Testing BFCache support for page with closed WebSocket connection and "Cache-Control: no-store" header.]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/websockets/back-forward-cache-with-closed-websocket-connection.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[back-forward-cache-with-closed-websocket-connection.window.html]
expected: TIMEOUT
[Testing BFCache support for page with closed WebSocket connection.]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/websockets/back-forward-cache-with-open-websocket-connection-ccns.tentative.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[back-forward-cache-with-open-websocket-connection-ccns.tentative.window.html]
expected: TIMEOUT
[Testing BFCache support for page with open WebSocket connection and "Cache-Control: no-store" header.]
expected: FAIL
expected: TIMEOUT

3
tests/wpt/meta/websockets/back-forward-cache-with-open-websocket-connection.window.js.ini vendored
View file

@ -1,3 +1,4 @@
[back-forward-cache-with-open-websocket-connection.window.html]
expected: TIMEOUT
[Testing BFCache support for page with open WebSocket connection.]
expected: FAIL
expected: TIMEOUT

4
tests/wpt/mozilla/meta/MANIFEST.json vendored
View file

@ -13775,14 +13775,14 @@
]
],
"interfaces.https.html": [
"1397b723a1cb001521ac1b2032c380f1e02cf1f0",
"8f56cc48648cc2aeced4c5cf081296b85a5ede43",
[
null,
{}
]
],
"interfaces.worker.js": [
"66f95241d5518a6b82725529775dc5613cbab1c0",
"8c0d87402f7675a6828343a18dec67c3cbe3a62a",
[
"mozilla/interfaces.worker.html",
{}

2
tests/wpt/mozilla/tests/mozilla/interfaces.https.html vendored
View file

@ -11,6 +11,8 @@
// IMPORTANT: Do not change the list below without review from a DOM peer!
test_interfaces([
"AbortController",
"AbortSignal",
"AbstractRange",
"AnalyserNode",
"AnimationEvent",

2
tests/wpt/mozilla/tests/mozilla/interfaces.worker.js vendored
View file

@ -7,6 +7,8 @@ importScripts("interfaces.js");
// IMPORTANT: Do not change the list below without review from a DOM peer!
test_interfaces([
"AbortController",
"AbortSignal",
"Blob",
"BroadcastChannel",
"ByteLengthQueuingStrategy",