Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-31 19:20:22 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #9405 - pcwalton:absolute-positioning-overflow, r=glennw

Browse source 
layout: Remove some bogus code that tried to handle absolutely-positioned flows separately when storing overflow.

This code dates back to the time when absolutely positioned flows were
ignored by all of their ancestors up to the containing block. This
hasn't been true for at least a year.

Closes #9306.
Closes #9309.
Is a partial fix for #9308.

r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9405)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2016-01-26 00:20:26 +05:30
commit 4755cc5c62
5 changed files with 75 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

7
components/layout/flow.rs
View file

@ -251,13 +251,6 @@ pub trait Flow: fmt::Debug + Sync + Send + 'static {
container_size);
overflow = overflow.union(&kid_overflow.translate(&kid_position.origin))
}
for kid in mut_base(self).abs_descendants.iter() {
let kid_overflow = base(kid).overflow;
let kid_position = base(kid).position.to_physical(base(kid).writing_mode,
container_size);
overflow = overflow.union(&kid_overflow.translate(&kid_position.origin))
}
}
_ => {}
}

18
tests/html/overflow-bug-0.html Normal file
View file

@ -0,0 +1,18 @@
<!DOCTYPE html>
<!-- https://github.com/servo/servo/issues/9306 -->
<style>
body {
margin: 0;
}
.green {
background: #0F0;
height: 40px;
width: 600px;
margin-left: -300px;
}
</style>
<div class="green">
</div>

29
tests/html/overflow-bug-1.html Normal file
View file

@ -0,0 +1,29 @@
<!DOCTYPE html>
<!-- https://github.com/servo/servo/issues/9306 -->
<style>
body {
margin: 0;
}
.green {
background: #0F0;
height: 40px;
width: 400px;
top: 40px;
left: 50%;
margin-left: -300px;
position: absolute;
padding: 0px 100px;
}
.red {
background: #F00;
position: absolute;
right: 0;
}
</style>
<div class="green">
<span class="red">x</span>
</div>

28
tests/html/overflow-bug-2.html Normal file
View file

@ -0,0 +1,28 @@
<!DOCTYPE html>
<!-- https://github.com/servo/servo/issues/9309 -->
<style>
body {
margin: 0;
}
.a {
background: red;
width: 100%;
height: 100%;
position: absolute;
overflow: hidden;
}
.b {
background: green;
width: 40px;
height: 40px;
position: absolute;
right: -40px;
}
</style>
<div class="a">
<div class="b"></div>
</div>

3
tests/wpt/metadata-css/css21_dev/html4/numbers-units-018.htm.ini
View file

@ -1,3 +0,0 @@
[numbers-units-018.htm]
type: reftest
expected: FAIL