Use active uniforms data to implement gl.uniform* checks

components/canvas/webgl_thread.rs

@@ -817,12 +817,15 @@ impl WebGLImpl {
                 ctx.gl().uniform_4i(uniform_id, x, y, z, w),
             WebGLCommand::Uniform4iv(uniform_id, ref v) =>
                 ctx.gl().uniform_4iv(uniform_id, v),
-            WebGLCommand::UniformMatrix2fv(uniform_id, transpose,  ref v) =>
+            WebGLCommand::UniformMatrix2fv(uniform_id, ref v) => {
-                ctx.gl().uniform_matrix_2fv(uniform_id, transpose, v),
+                ctx.gl().uniform_matrix_2fv(uniform_id, false, v)
-            WebGLCommand::UniformMatrix3fv(uniform_id, transpose,  ref v) =>
+            }
-                ctx.gl().uniform_matrix_3fv(uniform_id, transpose, v),
+            WebGLCommand::UniformMatrix3fv(uniform_id, ref v) => {
-            WebGLCommand::UniformMatrix4fv(uniform_id, transpose,  ref v) =>
+                ctx.gl().uniform_matrix_3fv(uniform_id, false, v)
-                ctx.gl().uniform_matrix_4fv(uniform_id, transpose, v),
+            }
+            WebGLCommand::UniformMatrix4fv(uniform_id, ref v) => {
+                ctx.gl().uniform_matrix_4fv(uniform_id, false, v)
+            }
             WebGLCommand::ValidateProgram(program_id) =>
                 ctx.gl().validate_program(program_id.get()),
             WebGLCommand::VertexAttrib(attrib_id, x, y, z, w) =>
@@ -1032,10 +1035,16 @@ impl WebGLImpl {
         let active_uniforms = (0..num_active_uniforms[0] as u32).map(|i| {
             // FIXME(nox): This allocates strings sometimes for nothing
             // and the gleam method keeps getting ACTIVE_UNIFORM_MAX_LENGTH.
-            let (size, type_, name) = gl.get_active_uniform(program.get(), i);
+            let (size, type_, mut name) = gl.get_active_uniform(program.get(), i);
+            let is_array = name.ends_with("[0]");
+            if is_array {
+                // FIXME(nox): NLL
+                let len = name.len();
+                name.truncate(len - 3);
+            }
             ActiveUniformInfo {
-                name: from_name_in_compiled_shader(&name),
+                base_name: from_name_in_compiled_shader(&name).into(),
-                size,
+                size: if is_array { Some(size) } else { None },
                 type_,
             }
         }).collect::<Vec<_>>().into();
@@ -1105,15 +1114,10 @@ impl WebGLImpl {
         gl: &gl::Gl,
         program_id: WebGLProgramId,
         name: &str,
-        chan: &WebGLSender<Option<i32>>,
+        chan: &WebGLSender<i32>,
     ) {
         let location = gl.get_uniform_location(program_id.get(), &to_name_in_compiled_shader(name));
-        let location = if location == -1 {
+        assert!(location >= 0);
-            None
-        } else {
-            Some(location)
-        };
-
         chan.send(location).unwrap();
     }
 

components/canvas_traits/webgl.rs

@@ -6,6 +6,7 @@ use euclid::Size2D;
 use gleam::gl;
 use offscreen_gl_context::{GLContextAttributes, GLLimits};
 use serde_bytes::ByteBuf;
+use std::borrow::Cow;
 use std::num::NonZeroU32;
 use webrender_api::{DocumentId, ImageKey, PipelineId};
 
@@ -207,7 +208,7 @@ pub enum WebGLCommand {
     FramebufferTexture2D(u32, u32, u32, Option<WebGLTextureId>, i32),
     GetExtensions(WebGLSender<String>),
     GetShaderPrecisionFormat(u32, u32, WebGLSender<(i32, i32, i32)>),
-    GetUniformLocation(WebGLProgramId, String, WebGLSender<Option<i32>>),
+    GetUniformLocation(WebGLProgramId, String, WebGLSender<i32>),
     GetShaderInfoLog(WebGLShaderId, WebGLSender<String>),
     GetProgramInfoLog(WebGLProgramId, WebGLSender<String>),
     GetFramebufferAttachmentParameter(u32, u32, u32, WebGLSender<i32>),
@@ -244,9 +245,9 @@ pub enum WebGLCommand {
     Uniform4fv(i32, Vec<f32>),
     Uniform4i(i32, i32, i32, i32, i32),
     Uniform4iv(i32, Vec<i32>),
-    UniformMatrix2fv(i32, bool, Vec<f32>),
+    UniformMatrix2fv(i32, Vec<f32>),
-    UniformMatrix3fv(i32, bool, Vec<f32>),
+    UniformMatrix3fv(i32, Vec<f32>),
-    UniformMatrix4fv(i32, bool, Vec<f32>),
+    UniformMatrix4fv(i32, Vec<f32>),
     UseProgram(Option<WebGLProgramId>),
     ValidateProgram(WebGLProgramId),
     VertexAttrib(u32, f32, f32, f32, f32),
@@ -443,14 +444,26 @@ pub struct ActiveAttribInfo {
 /// Description of a single active uniform.
 #[derive(Clone, Deserialize, MallocSizeOf, Serialize)]
 pub struct ActiveUniformInfo {
-    /// The name of the uniform.
+    /// The base name of the uniform.
-    pub name: String,
+    pub base_name: Box<str>,
-    /// The size of the uniform.
+    /// The size of the uniform, if it is an array.
-    pub size: i32,
+    pub size: Option<i32>,
     /// The type of the uniform.
     pub type_: u32,
 }
 
+impl ActiveUniformInfo {
+    pub fn name(&self) -> Cow<str> {
+        if self.size.is_some() {
+            let mut name = String::from(&*self.base_name);
+            name.push_str("[0]");
+            Cow::Owned(name)
+        } else {
+            Cow::Borrowed(&self.base_name)
+        }
+    }
+}
+
 macro_rules! parameters {
     ($name:ident { $(
         $variant:ident($kind:ident { $(

components/script/dom/webglprogram.rs

@@ -15,6 +15,7 @@ use dom::webglactiveinfo::WebGLActiveInfo;
 use dom::webglobject::WebGLObject;
 use dom::webglrenderingcontext::MAX_UNIFORM_AND_ATTRIBUTE_LEN;
 use dom::webglshader::WebGLShader;
+use dom::webgluniformlocation::WebGLUniformLocation;
 use dom::window::Window;
 use dom_struct::dom_struct;
 use fnv::FnvHashSet;
@@ -147,7 +148,7 @@ impl WebGLProgram {
             }
             for active_uniform in &*link_info.active_uniforms {
                 // https://www.khronos.org/registry/webgl/specs/latest/1.0/#6.41
-                if !used_names.insert(&*active_uniform.name) {
+                if !used_names.insert(&*active_uniform.base_name) {
                     return Ok(());
                 }
             }
@@ -262,9 +263,9 @@ impl WebGLProgram {
         let data = uniforms.get(index as usize).ok_or(WebGLError::InvalidValue)?;
         Ok(WebGLActiveInfo::new(
             self.global().as_window(),
-            data.size,
+            data.size.unwrap_or(1),
             data.type_,
-            data.name.clone().into(),
+            data.name().into(),
         ))
     }
 
@@ -311,7 +312,10 @@ impl WebGLProgram {
     }
 
     /// glGetUniformLocation
-    pub fn get_uniform_location(&self, name: DOMString) -> WebGLResult<Option<i32>> {
+    pub fn get_uniform_location(
+        &self,
+        name: DOMString,
+    ) -> WebGLResult<Option<DomRoot<WebGLUniformLocation>>> {
         if !self.is_linked() || self.is_deleted() {
             return Err(WebGLError::InvalidOperation);
         }
@@ -320,15 +324,37 @@ impl WebGLProgram {
         }
 
         // Check if the name is reserved
-        if name.starts_with("webgl") || name.starts_with("_webgl_") {
+        if name.starts_with("gl_") {
             return Ok(None);
         }
 
+        // https://www.khronos.org/registry/webgl/specs/latest/1.0/#GLSL_CONSTRUCTS
+        if name.starts_with("webgl_") || name.starts_with("_webgl_") {
+            return Ok(None);
+        }
+
+        let (size, type_) = {
+            let (base_name, array_index) = match parse_uniform_name(&name) {
+                Some((name, index)) if index.map_or(true, |i| i >= 0) => (name, index),
+                _ => return Ok(None),
+            };
+
+            let uniforms = self.active_uniforms.borrow();
+            match uniforms.iter().find(|attrib| &*attrib.base_name == base_name) {
+                Some(uniform) if array_index.is_none() || array_index < uniform.size => {
+                    (uniform.size.map(|size| size - array_index.unwrap_or_default()), uniform.type_)
+                },
+                _ => return Ok(None),
+            }
+        };
+
         let (sender, receiver) = webgl_channel().unwrap();
         self.renderer
             .send(WebGLCommand::GetUniformLocation(self.id, name.into(), sender))
             .unwrap();
-        Ok(receiver.recv().unwrap())
+        let location = receiver.recv().unwrap();
+
+        Ok(Some(WebGLUniformLocation::new(self.global().as_window(), location, self.id, size, type_)))
     }
 
     /// glGetProgramInfoLog
@@ -369,3 +395,13 @@ impl Drop for WebGLProgram {
         self.delete();
     }
 }
+
+
+fn parse_uniform_name(name: &str) -> Option<(&str, Option<i32>)> {
+    if !name.ends_with(']') {
+        return Some((name, None));
+    }
+    let bracket_pos = name[..name.len() - 1].rfind('[')?;
+    let index = name[(bracket_pos + 1)..(name.len() - 1)].parse::<i32>().ok()?;
+    Some((&name[..bracket_pos], Some(index)))
+}

components/script/dom/webglrenderingcontext.rs

@@ -425,6 +425,21 @@ impl WebGLRenderingContext {
         }
     }
 
+    fn with_location<F>(&self, location: Option<&WebGLUniformLocation>, f: F)
+    where
+        F: FnOnce(&WebGLUniformLocation) -> WebGLResult<()>,
+    {
+        let location = match location {
+            Some(loc) => loc,
+            None => return,
+        };
+        match self.current_program.get() {
+            Some(ref program) if program.id() == location.program_id() => {}
+            _ => return self.webgl_error(InvalidOperation),
+        }
+        handle_potential_webgl_error!(self, f(location));
+    }
+
     fn tex_parameter(&self, target: u32, name: u32, value: TexParameterValue) {
         let texture = match target {
             constants::TEXTURE_2D |
@@ -528,38 +543,6 @@ impl WebGLRenderingContext {
         }
     }
 
-    // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
-    // https://www.khronos.org/opengles/sdk/docs/man/xhtml/glUniform.xml
-    // https://www.khronos.org/registry/gles/specs/2.0/es_full_spec_2.0.25.pdf#nameddest=section-2.10.4
-    fn validate_uniform_parameters<T>(&self,
-                                      uniform: Option<&WebGLUniformLocation>,
-                                      uniform_type: UniformSetterType,
-                                      data: &[T]) -> bool {
-        let uniform = match uniform {
-            Some(uniform) => uniform,
-            None => return false,
-        };
-
-        let program = self.current_program.get();
-        match program {
-            Some(ref program) if program.id() == uniform.program_id() => {},
-            _ => {
-                self.webgl_error(InvalidOperation);
-                return false;
-            },
-        };
-
-        // TODO(emilio): Get more complex uniform info from ANGLE, and use it to
-        // properly validate that the uniform setter type is compatible with the
-        // uniform type, and that the uniform size matches.
-        if data.len() % uniform_type.element_count() != 0 {
-            self.webgl_error(InvalidOperation);
-            return false;
-        }
-
-        true
-    }
-
     // https://en.wikipedia.org/wiki/Relative_luminance
     #[inline]
     fn luminance(r: u8, g: u8, b: u8) -> u8 {
@@ -2762,9 +2745,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
         program: &WebGLProgram,
         name: DOMString,
     ) -> Option<DomRoot<WebGLUniformLocation>> {
-        handle_potential_webgl_error!(self, program.get_uniform_location(name), None).map(|location| {
+        handle_potential_webgl_error!(self, program.get_uniform_location(name), None)
-            WebGLUniformLocation::new(self.global().as_window(), location, program.id())
-        })
     }
 
     #[allow(unsafe_code)]
@@ -3166,75 +3147,145 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
-    fn Uniform1f(&self,
+    fn Uniform1f(
+        &self,
         location: Option<&WebGLUniformLocation>,
-                  val: f32) {
+        val: f32,
-        if self.validate_uniform_parameters(location, UniformSetterType::Float, &[val]) {
+    ) {
-            self.send_command(WebGLCommand::Uniform1f(location.unwrap().id(), val))
+        self.with_location(location, |location| {
+            match location.type_() {
+                constants::BOOL | constants::FLOAT => {}
+                _ => return Err(InvalidOperation),
             }
+            self.send_command(WebGLCommand::Uniform1f(location.id(), val));
+            Ok(())
+        });
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
-    fn Uniform1i(&self,
+    fn Uniform1i(
+        &self,
         location: Option<&WebGLUniformLocation>,
-                  val: i32) {
+        val: i32,
-        if self.validate_uniform_parameters(location, UniformSetterType::Int, &[val]) {
+    ) {
-            self.send_command(WebGLCommand::Uniform1i(location.unwrap().id(), val))
+        self.with_location(location, |location| {
+            match location.type_() {
+                constants::BOOL | constants::INT => {}
+                constants::SAMPLER_2D | constants::SAMPLER_CUBE => {
+                    if val < 0 || val as u32 >= self.limits.max_combined_texture_image_units {
+                        return Err(InvalidValue);
                     }
                 }
+                _ => return Err(InvalidOperation),
+            }
+            self.send_command(WebGLCommand::Uniform1i(location.id(), val));
+            Ok(())
+        });
+    }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
     fn Uniform1iv(
         &self,
         location: Option<&WebGLUniformLocation>,
-        v: Int32ArrayOrLongSequence,
+        val: Int32ArrayOrLongSequence,
     ) {
-        let v = match v {
+        self.with_location(location, |location| {
+            match location.type_() {
+                constants::BOOL | constants::INT | constants::SAMPLER_2D | constants::SAMPLER_CUBE => {}
+                _ => return Err(InvalidOperation),
+            }
+            let val = match val {
                 Int32ArrayOrLongSequence::Int32Array(v) => v.to_vec(),
                 Int32ArrayOrLongSequence::LongSequence(v) => v,
             };
-        if self.validate_uniform_parameters(location, UniformSetterType::Int, &v) {
+            if val.is_empty() {
-            self.send_command(WebGLCommand::Uniform1iv(location.unwrap().id(), v))
+                return Err(InvalidValue);
             }
+            if location.size().is_none() && val.len() != 1 {
+                return Err(InvalidOperation);
+            }
+            match location.type_() {
+                constants::SAMPLER_2D | constants::SAMPLER_CUBE => {
+                    for &v in val.iter().take(cmp::min(location.size().unwrap_or(1) as usize, val.len())) {
+                        if v < 0 || v as u32 >= self.limits.max_combined_texture_image_units {
+                            return Err(InvalidValue);
+                        }
+                    }
+                }
+                _ => {}
+            }
+            self.send_command(WebGLCommand::Uniform1iv(location.id(), val));
+            Ok(())
+        });
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
     fn Uniform1fv(
         &self,
         location: Option<&WebGLUniformLocation>,
-        v: Float32ArrayOrUnrestrictedFloatSequence,
+        val: Float32ArrayOrUnrestrictedFloatSequence,
     ) {
-        let v = match v {
+        self.with_location(location, |location| {
+            match location.type_() {
+                constants::BOOL | constants::FLOAT => {}
+                _ => return Err(InvalidOperation),
+            }
+            let val = match val {
                 Float32ArrayOrUnrestrictedFloatSequence::Float32Array(v) => v.to_vec(),
                 Float32ArrayOrUnrestrictedFloatSequence::UnrestrictedFloatSequence(v) => v,
             };
-        if self.validate_uniform_parameters(location, UniformSetterType::Float, &v) {
+            if val.is_empty() {
-            self.send_command(WebGLCommand::Uniform1fv(location.unwrap().id(), v));
+                return Err(InvalidValue);
             }
+            if location.size().is_none() && val.len() != 1 {
+                return Err(InvalidOperation);
+            }
+            self.send_command(WebGLCommand::Uniform1fv(location.id(), val));
+            Ok(())
+        });
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
-    fn Uniform2f(&self,
+    fn Uniform2f(
+        &self,
         location: Option<&WebGLUniformLocation>,
-                  x: f32, y: f32) {
+        x: f32,
-        if self.validate_uniform_parameters(location, UniformSetterType::FloatVec2, &[x, y]) {
+        y: f32,
-            self.send_command(WebGLCommand::Uniform2f(location.unwrap().id(), x, y));
+    ) {
+        self.with_location(location, |location| {
+            match location.type_() {
+                constants::BOOL_VEC2 | constants::FLOAT_VEC2 => {}
+                _ => return Err(InvalidOperation),
             }
+            self.send_command(WebGLCommand::Uniform2f(location.id(), x, y));
+            Ok(())
+        });
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
     fn Uniform2fv(
         &self,
         location: Option<&WebGLUniformLocation>,
-        v: Float32ArrayOrUnrestrictedFloatSequence,
+        val: Float32ArrayOrUnrestrictedFloatSequence,
     ) {
-        let v = match v {
+        self.with_location(location, |location| {
+            match location.type_() {
+                constants::BOOL_VEC2 | constants::FLOAT_VEC2 => {}
+                _ => return Err(InvalidOperation),
+            }
+            let val = match val {
                 Float32ArrayOrUnrestrictedFloatSequence::Float32Array(v) => v.to_vec(),
                 Float32ArrayOrUnrestrictedFloatSequence::UnrestrictedFloatSequence(v) => v,
             };
-        if self.validate_uniform_parameters(location, UniformSetterType::FloatVec2, &v) {
+            if val.len() < 2 || val.len() % 2 != 0 {
-            self.send_command(WebGLCommand::Uniform2fv(location.unwrap().id(), v));
+                return Err(InvalidValue);
             }
+            if location.size().is_none() && val.len() != 2 {
+                return Err(InvalidOperation);
+            }
+            self.send_command(WebGLCommand::Uniform2fv(location.id(), val));
+            Ok(())
+        });
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
@@ -3244,26 +3295,40 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
         x: i32,
         y: i32,
     ) {
-        if self.validate_uniform_parameters(location,
+        self.with_location(location, |location| {
-                                            UniformSetterType::IntVec2,
+            match location.type_() {
-                                            &[x, y]) {
+                constants::BOOL_VEC2 | constants::INT_VEC2 => {}
-            self.send_command(WebGLCommand::Uniform2i(location.unwrap().id(), x, y));
+                _ => return Err(InvalidOperation),
             }
+            self.send_command(WebGLCommand::Uniform2i(location.id(), x, y));
+            Ok(())
+        });
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
     fn Uniform2iv(
         &self,
         location: Option<&WebGLUniformLocation>,
-        v: Int32ArrayOrLongSequence,
+        val: Int32ArrayOrLongSequence,
     ) {
-        let v = match v {
+        self.with_location(location, |location| {
+            match location.type_() {
+                constants::BOOL_VEC2 | constants::INT_VEC2 => {}
+                _ => return Err(InvalidOperation),
+            }
+            let val = match val {
                 Int32ArrayOrLongSequence::Int32Array(v) => v.to_vec(),
                 Int32ArrayOrLongSequence::LongSequence(v) => v,
             };
-        if self.validate_uniform_parameters(location, UniformSetterType::IntVec2, &v) {
+            if val.len() < 2 || val.len() % 2 != 0 {
-            self.send_command(WebGLCommand::Uniform2iv(location.unwrap().id(), v));
+                return Err(InvalidValue);
             }
+            if location.size().is_none() && val.len() != 2 {
+                return Err(InvalidOperation);
+            }
+            self.send_command(WebGLCommand::Uniform2iv(location.id(), val));
+            Ok(())
+        });
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
@@ -3274,52 +3339,84 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
         y: f32,
         z: f32,
     ) {
-        if self.validate_uniform_parameters(location,
+        self.with_location(location, |location| {
-                                            UniformSetterType::FloatVec3,
+            match location.type_() {
-                                            &[x, y, z]) {
+                constants::BOOL_VEC3 | constants::FLOAT_VEC3 => {}
-            self.send_command(WebGLCommand::Uniform3f(location.unwrap().id(), x, y, z));
+                _ => return Err(InvalidOperation),
             }
+            self.send_command(WebGLCommand::Uniform3f(location.id(), x, y, z));
+            Ok(())
+        });
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
     fn Uniform3fv(
         &self,
         location: Option<&WebGLUniformLocation>,
-        v: Float32ArrayOrUnrestrictedFloatSequence,
+        val: Float32ArrayOrUnrestrictedFloatSequence,
     ) {
-        let v = match v {
+        self.with_location(location, |location| {
+            match location.type_() {
+                constants::BOOL_VEC3 | constants::FLOAT_VEC3 => {}
+                _ => return Err(InvalidOperation),
+            }
+            let val = match val {
                 Float32ArrayOrUnrestrictedFloatSequence::Float32Array(v) => v.to_vec(),
                 Float32ArrayOrUnrestrictedFloatSequence::UnrestrictedFloatSequence(v) => v,
             };
-        if self.validate_uniform_parameters(location, UniformSetterType::FloatVec3, &v) {
+            if val.len() < 3 || val.len() % 3 != 0 {
-            self.send_command(WebGLCommand::Uniform3fv(location.unwrap().id(), v))
+                return Err(InvalidValue);
             }
+            if location.size().is_none() && val.len() != 3 {
+                return Err(InvalidOperation);
+            }
+            self.send_command(WebGLCommand::Uniform3fv(location.id(), val));
+            Ok(())
+        });
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
-    fn Uniform3i(&self,
+    fn Uniform3i(
+        &self,
         location: Option<&WebGLUniformLocation>,
-                  x: i32, y: i32, z: i32) {
+        x: i32,
-        if self.validate_uniform_parameters(location,
+        y: i32,
-                                            UniformSetterType::IntVec3,
+        z: i32,
-                                            &[x, y, z]) {
+    ) {
-            self.send_command(WebGLCommand::Uniform3i(location.unwrap().id(), x, y, z))
+        self.with_location(location, |location| {
+            match location.type_() {
+                constants::BOOL_VEC3 | constants::INT_VEC3 => {}
+                _ => return Err(InvalidOperation),
             }
+            self.send_command(WebGLCommand::Uniform3i(location.id(), x, y, z));
+            Ok(())
+        });
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
     fn Uniform3iv(
         &self,
         location: Option<&WebGLUniformLocation>,
-        v: Int32ArrayOrLongSequence,
+        val: Int32ArrayOrLongSequence,
     ) {
-        let v = match v {
+        self.with_location(location, |location| {
+            match location.type_() {
+                constants::BOOL_VEC3 | constants::INT_VEC3 => {}
+                _ => return Err(InvalidOperation),
+            }
+            let val = match val {
                 Int32ArrayOrLongSequence::Int32Array(v) => v.to_vec(),
                 Int32ArrayOrLongSequence::LongSequence(v) => v,
             };
-        if self.validate_uniform_parameters(location, UniformSetterType::IntVec3, &v) {
+            if val.len() < 3 || val.len() % 3 != 0 {
-            self.send_command(WebGLCommand::Uniform3iv(location.unwrap().id(), v))
+                return Err(InvalidValue);
             }
+            if location.size().is_none() && val.len() != 3 {
+                return Err(InvalidOperation);
+            }
+            self.send_command(WebGLCommand::Uniform3iv(location.id(), val));
+            Ok(())
+        });
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
@@ -3331,11 +3428,14 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
         z: i32,
         w: i32,
     ) {
-        if self.validate_uniform_parameters(location,
+        self.with_location(location, |location| {
-                                            UniformSetterType::IntVec4,
+            match location.type_() {
-                                            &[x, y, z, w]) {
+                constants::BOOL_VEC4 | constants::INT_VEC4 => {}
-            self.send_command(WebGLCommand::Uniform4i(location.unwrap().id(), x, y, z, w))
+                _ => return Err(InvalidOperation),
             }
+            self.send_command(WebGLCommand::Uniform4i(location.id(), x, y, z, w));
+            Ok(())
+        });
     }
 
 
@@ -3343,15 +3443,26 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
     fn Uniform4iv(
         &self,
         location: Option<&WebGLUniformLocation>,
-        v: Int32ArrayOrLongSequence,
+        val: Int32ArrayOrLongSequence,
     ) {
-        let v = match v {
+        self.with_location(location, |location| {
+            match location.type_() {
+                constants::BOOL_VEC4 | constants::INT_VEC4 => {}
+                _ => return Err(InvalidOperation),
+            }
+            let val = match val {
                 Int32ArrayOrLongSequence::Int32Array(v) => v.to_vec(),
                 Int32ArrayOrLongSequence::LongSequence(v) => v,
             };
-        if self.validate_uniform_parameters(location, UniformSetterType::IntVec4, &v) {
+            if val.len() < 4 || val.len() % 4 != 0 {
-            self.send_command(WebGLCommand::Uniform4iv(location.unwrap().id(), v))
+                return Err(InvalidValue);
             }
+            if location.size().is_none() && val.len() != 4 {
+                return Err(InvalidOperation);
+            }
+            self.send_command(WebGLCommand::Uniform4iv(location.id(), val));
+            Ok(())
+        });
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
@@ -3363,26 +3474,40 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
         z: f32,
         w: f32,
     ) {
-        if self.validate_uniform_parameters(location,
+        self.with_location(location, |location| {
-                                            UniformSetterType::FloatVec4,
+            match location.type_() {
-                                            &[x, y, z, w]) {
+                constants::BOOL_VEC4 | constants::FLOAT_VEC4 => {}
-            self.send_command(WebGLCommand::Uniform4f(location.unwrap().id(), x, y, z, w))
+                _ => return Err(InvalidOperation),
             }
+            self.send_command(WebGLCommand::Uniform4f(location.id(), x, y, z, w));
+            Ok(())
+        });
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
     fn Uniform4fv(
         &self,
         location: Option<&WebGLUniformLocation>,
-        v: Float32ArrayOrUnrestrictedFloatSequence,
+        val: Float32ArrayOrUnrestrictedFloatSequence,
     ) {
-        let v = match v {
+        self.with_location(location, |location| {
+            match location.type_() {
+                constants::BOOL_VEC4 | constants::FLOAT_VEC4 => {}
+                _ => return Err(InvalidOperation),
+            }
+            let val = match val {
                 Float32ArrayOrUnrestrictedFloatSequence::Float32Array(v) => v.to_vec(),
                 Float32ArrayOrUnrestrictedFloatSequence::UnrestrictedFloatSequence(v) => v,
             };
-        if self.validate_uniform_parameters(location, UniformSetterType::FloatVec4, &v) {
+            if val.len() < 4 || val.len() % 4 != 0 {
-            self.send_command(WebGLCommand::Uniform4fv(location.unwrap().id(), v))
+                return Err(InvalidValue);
             }
+            if location.size().is_none() && val.len() != 4 {
+                return Err(InvalidOperation);
+            }
+            self.send_command(WebGLCommand::Uniform4fv(location.id(), val));
+            Ok(())
+        });
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
@@ -3390,15 +3515,29 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
         &self,
         location: Option<&WebGLUniformLocation>,
         transpose: bool,
-        v: Float32ArrayOrUnrestrictedFloatSequence,
+        val: Float32ArrayOrUnrestrictedFloatSequence,
     ) {
-        let v = match v {
+        self.with_location(location, |location| {
+            match location.type_() {
+                constants::FLOAT_MAT2 => {}
+                _ => return Err(InvalidOperation),
+            }
+            let val = match val {
                 Float32ArrayOrUnrestrictedFloatSequence::Float32Array(v) => v.to_vec(),
                 Float32ArrayOrUnrestrictedFloatSequence::UnrestrictedFloatSequence(v) => v,
             };
-        if self.validate_uniform_parameters(location, UniformSetterType::FloatMat2, &v) {
+            if transpose {
-            self.send_command(WebGLCommand::UniformMatrix2fv(location.unwrap().id(), transpose, v));
+                return Err(InvalidValue);
             }
+            if val.len() < 4 || val.len() % 4 != 0 {
+                return Err(InvalidValue);
+            }
+            if location.size().is_none() && val.len() != 4 {
+                return Err(InvalidOperation);
+            }
+            self.send_command(WebGLCommand::UniformMatrix2fv(location.id(), val));
+            Ok(())
+        });
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
@@ -3406,15 +3545,29 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
         &self,
         location: Option<&WebGLUniformLocation>,
         transpose: bool,
-        v: Float32ArrayOrUnrestrictedFloatSequence,
+        val: Float32ArrayOrUnrestrictedFloatSequence,
     ) {
-        let v = match v {
+        self.with_location(location, |location| {
+            match location.type_() {
+                constants::FLOAT_MAT3 => {}
+                _ => return Err(InvalidOperation),
+            }
+            let val = match val {
                 Float32ArrayOrUnrestrictedFloatSequence::Float32Array(v) => v.to_vec(),
                 Float32ArrayOrUnrestrictedFloatSequence::UnrestrictedFloatSequence(v) => v,
             };
-        if self.validate_uniform_parameters(location, UniformSetterType::FloatMat3, &v) {
+            if transpose {
-            self.send_command(WebGLCommand::UniformMatrix3fv(location.unwrap().id(), transpose, v));
+                return Err(InvalidValue);
             }
+            if val.len() < 9 || val.len() % 9 != 0 {
+                return Err(InvalidValue);
+            }
+            if location.size().is_none() && val.len() != 9 {
+                return Err(InvalidOperation);
+            }
+            self.send_command(WebGLCommand::UniformMatrix3fv(location.id(), val));
+            Ok(())
+        });
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
@@ -3422,15 +3575,29 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
         &self,
         location: Option<&WebGLUniformLocation>,
         transpose: bool,
-        v: Float32ArrayOrUnrestrictedFloatSequence,
+        val: Float32ArrayOrUnrestrictedFloatSequence,
     ) {
-        let v = match v {
+        self.with_location(location, |location| {
+            match location.type_() {
+                constants::FLOAT_MAT4 => {}
+                _ => return Err(InvalidOperation),
+            }
+            let val = match val {
                 Float32ArrayOrUnrestrictedFloatSequence::Float32Array(v) => v.to_vec(),
                 Float32ArrayOrUnrestrictedFloatSequence::UnrestrictedFloatSequence(v) => v,
             };
-        if self.validate_uniform_parameters(location, UniformSetterType::FloatMat4, &v) {
+            if transpose {
-            self.send_command(WebGLCommand::UniformMatrix4fv(location.unwrap().id(), transpose, v));
+                return Err(InvalidValue);
             }
+            if val.len() < 16 || val.len() % 16 != 0 {
+                return Err(InvalidValue);
+            }
+            if location.size().is_none() && val.len() != 16 {
+                return Err(InvalidOperation);
+            }
+            self.send_command(WebGLCommand::UniformMatrix4fv(location.id(), val));
+            Ok(())
+        });
     }
 
     // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.9
@@ -3932,39 +4099,6 @@ impl LayoutCanvasWebGLRenderingContextHelpers for LayoutDom<WebGLRenderingContex
     }
 }
 
-#[derive(Debug, PartialEq)]
-pub enum UniformSetterType {
-    Int,
-    IntVec2,
-    IntVec3,
-    IntVec4,
-    Float,
-    FloatVec2,
-    FloatVec3,
-    FloatVec4,
-    FloatMat2,
-    FloatMat3,
-    FloatMat4,
-}
-
-impl UniformSetterType {
-    pub fn element_count(&self) -> usize {
-        match *self {
-            UniformSetterType::Int => 1,
-            UniformSetterType::IntVec2 => 2,
-            UniformSetterType::IntVec3 => 3,
-            UniformSetterType::IntVec4 => 4,
-            UniformSetterType::Float => 1,
-            UniformSetterType::FloatVec2 => 2,
-            UniformSetterType::FloatVec3 => 3,
-            UniformSetterType::FloatVec4 => 4,
-            UniformSetterType::FloatMat2 => 4,
-            UniformSetterType::FloatMat3 => 9,
-            UniformSetterType::FloatMat4 => 16,
-        }
-    }
-}
-
 #[derive(JSTraceable, MallocSizeOf)]
 #[must_root]
 pub struct VertexAttribs {

components/script/dom/webgluniformlocation.rs

@@ -15,26 +15,38 @@ pub struct WebGLUniformLocation {
     reflector_: Reflector,
     id: i32,
     program_id: WebGLProgramId,
+    size: Option<i32>,
+    type_: u32,
 }
 
 impl WebGLUniformLocation {
-    fn new_inherited(id: i32,
+    fn new_inherited(
-                     program_id: WebGLProgramId)
+        id: i32,
-                     -> WebGLUniformLocation {
+        program_id: WebGLProgramId,
-        WebGLUniformLocation {
+        size: Option<i32>,
+        type_: u32,
+    ) -> Self {
+        Self {
             reflector_: Reflector::new(),
-            id: id,
+            id,
-            program_id: program_id,
+            program_id,
+            size,
+            type_,
         }
     }
 
-    pub fn new(window: &Window,
+    pub fn new(
+        window: &Window,
         id: i32,
-               program_id: WebGLProgramId)
+        program_id: WebGLProgramId,
-               -> DomRoot<WebGLUniformLocation> {
+        size: Option<i32>,
-        reflect_dom_object(Box::new(WebGLUniformLocation::new_inherited(id, program_id)),
+        type_: u32,
+    ) -> DomRoot<Self> {
+        reflect_dom_object(
+            Box::new(Self::new_inherited(id, program_id, size, type_)),
             window,
-                           WebGLUniformLocationBinding::Wrap)
+            WebGLUniformLocationBinding::Wrap,
+        )
     }
 
     pub fn id(&self) -> i32 {
@@ -44,4 +56,12 @@ impl WebGLUniformLocation {
     pub fn program_id(&self) -> WebGLProgramId {
         self.program_id
     }
+
+    pub fn size(&self) -> Option<i32> {
+        self.size
+    }
+
+    pub fn type_(&self) -> u32 {
+        self.type_
+    }
 }

tests/wpt/mozilla/meta/webgl/conformance-1.0.3/conformance/misc/type-conversion-test.html.ini

@@ -1,3 +1,20 @@
 [type-conversion-test.html]
   type: testharness
-  expected: CRASH
+  [WebGL test #340: context.bufferData(context.ARRAY_BUFFER, argument, context.STATIC_DRAW) should be undefined. Threw exception TypeError: Not an ArrayBufferView]
+    expected: FAIL
+
+  [WebGL test #407: context.bufferData(context.ARRAY_BUFFER, argument, context.STATIC_DRAW) should be undefined. Threw exception TypeError: Not an ArrayBufferView]
+    expected: FAIL
+
+  [WebGL test #474: context.bufferData(context.ARRAY_BUFFER, argument, context.STATIC_DRAW) should be undefined. Threw exception TypeError: Not an ArrayBufferView]
+    expected: FAIL
+
+  [WebGL test #541: context.bufferData(context.ARRAY_BUFFER, argument, context.STATIC_DRAW) should be undefined. Threw exception TypeError: Not an ArrayBufferView]
+    expected: FAIL
+
+  [WebGL test #608: context.bufferData(context.ARRAY_BUFFER, argument, context.STATIC_DRAW) should be undefined. Threw exception TypeError: Not an ArrayBufferView]
+    expected: FAIL
+
+  [WebGL test #675: context.bufferData(context.ARRAY_BUFFER, argument, context.STATIC_DRAW) should be undefined. Threw exception TypeError: Not an ArrayBufferView]
+    expected: FAIL
+

tests/wpt/mozilla/meta/webgl/conformance-1.0.3/conformance/more/functions/uniformMatrixBadArgs.html.ini

@@ -1,3 +1,5 @@
 [uniformMatrixBadArgs.html]
   type: testharness
-  expected: CRASH
+  [WebGL test #0: testUniformf]
+    expected: FAIL
+

tests/wpt/mozilla/meta/webgl/conformance-1.0.3/conformance/more/functions/uniformfBadArgs.html.ini

@@ -1,6 +0,0 @@
-[uniformfBadArgs.html]
-  type: testharness
-  expected: CRASH
-  [WebGL test #0: testUniformf]
-    expected: FAIL
-

tests/wpt/mozilla/meta/webgl/conformance-1.0.3/conformance/more/functions/uniformiBadArgs.html.ini

@@ -1,6 +0,0 @@
-[uniformiBadArgs.html]
-  type: testharness
-  expected: CRASH
-  [WebGL test #0: testUniformf]
-    expected: FAIL
-

tests/wpt/mozilla/meta/webgl/conformance-1.0.3/conformance/uniforms/gl-uniform-arrays.html.ini

@@ -1,3 +1,5 @@
 [gl-uniform-arrays.html]
-  type: testharness
+  expected: ERROR
-  disabled: flaky
+  [Overall test]
+    expected: NOTRUN
+

tests/wpt/mozilla/meta/webgl/conformance-1.0.3/conformance/uniforms/gl-uniformmatrix4fv.html.ini

@@ -1,35 +0,0 @@
-[gl-uniformmatrix4fv.html]
-  type: testharness
-  [WebGL test #0: successfullyParsed should be true (of type boolean). Was undefined (of type undefined).]
-    expected: FAIL
-
-  [WebGL uniformMatrix Conformance Tests]
-    expected: FAIL
-
-  [WebGL test #0: getError expected: INVALID_VALUE. Was INVALID_OPERATION : should fail with insufficient array size for uniformMatrix2fv]
-    expected: FAIL
-
-  [WebGL test #2: getError expected: INVALID_VALUE. Was INVALID_OPERATION : should fail with more than 1 array size for uniformMatrix2fv]
-    expected: FAIL
-
-  [WebGL test #4: getError expected: INVALID_VALUE. Was NO_ERROR : uniformMatrix2fv should return INVALID_VALUE with transpose = true]
-    expected: FAIL
-
-  [WebGL test #5: getError expected: INVALID_VALUE. Was INVALID_OPERATION : should fail with insufficient array size for uniformMatrix3fv]
-    expected: FAIL
-
-  [WebGL test #7: getError expected: INVALID_VALUE. Was INVALID_OPERATION : should fail with more than 1 array size for uniformMatrix3fv]
-    expected: FAIL
-
-  [WebGL test #9: getError expected: INVALID_VALUE. Was NO_ERROR : uniformMatrix3fv should return INVALID_VALUE with transpose = true]
-    expected: FAIL
-
-  [WebGL test #10: getError expected: INVALID_VALUE. Was INVALID_OPERATION : should fail with insufficient array size for uniformMatrix4fv]
-    expected: FAIL
-
-  [WebGL test #12: getError expected: INVALID_VALUE. Was INVALID_OPERATION : should fail with more than 1 array size for uniformMatrix4fv]
-    expected: FAIL
-
-  [WebGL test #14: getError expected: INVALID_VALUE. Was NO_ERROR : uniformMatrix4fv should return INVALID_VALUE with transpose = true]
-    expected: FAIL
-

tests/wpt/mozilla/meta/webgl/conformance-1.0.3/conformance/uniforms/uniform-default-values.html.ini

@@ -1,9 +1,5 @@
 [uniform-default-values.html]
-  type: testharness
   expected: ERROR
-  [WebGL uniform default values]
-    expected: FAIL
-
   [Overall test]
     expected: NOTRUN
 

tests/wpt/mozilla/meta/webgl/conformance-1.0.3/conformance/uniforms/uniform-location.html.ini

@@ -1,5 +1,4 @@
 [uniform-location.html]
-  type: testharness
   [WebGL test #9: contextA.getUniform(programS, locationSx) should be 333. Threw exception TypeError: contextA.getUniform is not a function]
     expected: FAIL
 

tests/wpt/mozilla/meta/webgl/conformance-1.0.3/conformance/uniforms/uniform-samplers-test.html.ini

@@ -1,3 +0,0 @@
-[uniform-samplers-test.html]
-  type: testharness
-  disabled: flaky