Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

Don't clone the result of AttrHelpersForLayout::local_name

Browse source 
There is no need to do that. Embrace returning borrows from the DOM, it good.
This commit is contained in:
Anthony Ramine 2020-03-31 14:02:14 +02:00
parent 4db84bede8
commit 47c9f19121
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/script/dom/attr.rs
View file

@ -237,7 +237,7 @@ pub trait AttrHelpersForLayout<'dom> {
fn value(self) -> &'dom AttrValue; fn value(self) -> &'dom AttrValue;
fn as_str(self) -> &'dom str; fn as_str(self) -> &'dom str;
fn as_tokens(self) -> Option<&'dom [Atom]>; fn as_tokens(self) -> Option<&'dom [Atom]>;
fn local_name(self) -> LocalName; fn local_name(self) -> &'dom LocalName;
} }
#[allow(unsafe_code)] #[allow(unsafe_code)]
@ -262,7 +262,7 @@ impl<'dom> AttrHelpersForLayout<'dom> for LayoutDom<'dom, Attr> {
} }
#[inline] #[inline]
fn local_name(self) -> LocalName { fn local_name(self) -> &'dom LocalName {
unsafe { self.unsafe_get().identifier.local_name.clone() } unsafe { &self.unsafe_get().identifier.local_name }
} }
} }

4
components/script/dom/element.rs
View file

@ -578,7 +578,7 @@ pub unsafe fn get_attr_for_layout<'dom>(
.iter() .iter()
.find(|attr| { .find(|attr| {
let attr = attr.to_layout(); let attr = attr.to_layout();
*name == attr.local_name() && (*attr.unsafe_get()).namespace() == namespace name == attr.local_name() && (*attr.unsafe_get()).namespace() == namespace
}) })
.map(|attr| attr.to_layout()) .map(|attr| attr.to_layout())
} }
@ -610,7 +610,7 @@ impl RawLayoutElementHelpers for Element {
.iter() .iter()
.filter_map(|attr| { .filter_map(|attr| {
let attr = attr.to_layout(); let attr = attr.to_layout();
if *name == attr.local_name() { if name == attr.local_name() {
Some(attr.value()) Some(attr.value())
} else { } else {
None None