Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-10 16:05:43 +01:00
Code Issues Projects Releases Packages Wiki Activity

Add width and height presentational hints for table-related elements (#33405)

Browse source 
We were only parsing the `width` attribute as a presentation hint for
`<table>`, `<td>` and `<th>`. This patch also handles `<colgroup>` and
`<col>`.

Also, we weren't parsing `height` at all, now we do it for `<table>`,
`<td>`, `<th>`, `<tr>`, `<tbody>`, `<thead>` and `<tfoot>`.

One test is now crashing, but this was an existing issue: #33423

Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Oriol Brufau 2024-09-12 15:34:20 +02:00 • committed by GitHub
parent 37ab4b9825
commit 4839cdf176
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
16 changed files with 65 additions and 228 deletions
Download patch file Download diff file Expand all files Collapse all files

15
tests/wpt/meta/html/rendering/non-replaced-elements/tables/table-attribute.html.ini vendored
View file

@ -128,30 +128,18 @@
[table th align attribute justify is correct]
expected: FAIL
[tr height attribute pixel is correct]
expected: FAIL
[td height attribute pixel is correct]
expected: FAIL
[th height attribute pixel is correct]
expected: FAIL
[table_tr height attribute percentage is correct]
expected: FAIL
[table_td height attribute percentage is correct]
expected: FAIL
[table_th height attribute percentage is correct]
expected: FAIL
[table height attribute pixel is correct]
expected: FAIL
[table height attribute 90% is correct]
expected: FAIL
[table height attribute 110% is correct]
expected: FAIL
@ -160,6 +148,3 @@
[th default align attribute is center]
expected: FAIL
[table col width attribute is correct]
expected: FAIL

2
tests/wpt/meta/html/rendering/non-replaced-elements/tables/table-row-group-height.html.ini vendored
View file

@ -1,2 +0,0 @@
[table-row-group-height.html]
expected: FAIL