Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-10-03 10:09:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #18510 - mrobinson:truncated-fragment-stacking-context-collection, r=emilio

Browse source 
Properly handle stacking context collection for truncated fragments

Before we did not properly descend intro truncated fragments when
collecting stacking contexts. This change makes sure that we descend
properly

Fixes #18254.
Fixes #17072.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #18254,  #17072 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18510)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2017-09-15 19:00:24 -05:00 • committed by GitHub
commit 4911706f75
4 changed files with 104 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

25
tests/wpt/mozilla/meta/MANIFEST.json
View file

@ -6353,6 +6353,18 @@
{}
]
],
"css/truncated_text_fragment_stacking_context.html": [
[
"/_mozilla/css/truncated_text_fragment_stacking_context.html",
[
[
"/_mozilla/css/truncated_text_fragment_stacking_context_ref.html",
"=="
]
],
{}
]
],
"css/upper_id_attr.html": [
[
"/_mozilla/css/upper_id_attr.html",
@ -10547,6 +10559,11 @@
{}
]
],
"css/truncated_text_fragment_stacking_context_ref.html": [
[
{}
]
],
"css/upper_id_attr_ref.html": [
[
{}
@ -26893,6 +26910,14 @@
"c62420cce19d1d6a7d8700275daaa5ecc10d14c7",
"support"
],
"css/truncated_text_fragment_stacking_context.html": [
"453b01aec6ffd3c854fda854cf81250a332cd55c",
"reftest"
],
"css/truncated_text_fragment_stacking_context_ref.html": [
"4cb902bb7b058748d1702b5033e8cec729431640",
"support"
],
"css/upper_id_attr.html": [
"f9965c1c22379aba20ac08d03a5e0e86cb1d8b99",
"reftest"

33
tests/wpt/mozilla/tests/css/truncated_text_fragment_stacking_context.html Normal file
View file

@ -0,0 +1,33 @@
<!DOCTYPE html>
<title>Truncated text and inline-blocks combined should not cause a panic</title>
<link rel="match" href="truncated_text_fragment_stacking_context_ref.html" />
<link rel="help" href="https://www.w3.org/TR/css-position-3/#sticky-pos" />
<meta name="assert" content="This test checks that truncated text and inline-blocks don't cause a panic." />
<!-- We are using transparent text here to avoid having to deal with subpixel text rendering issues. -->
<style>
a {
float: left;
color: transparent;
}
p, em {
overflow:hidden
}
em {
display: inline-block;
text-overflow: ellipsis;
color: transparent;
}
div {
position: absolute
}
</style>
<div style="height: 100px; width: 100px; background: green;"></div>
<div>
<a>LINK</a>
<p><em>TEXT</em></p>
</div>

3
tests/wpt/mozilla/tests/css/truncated_text_fragment_stacking_context_ref.html Normal file
View file

@ -0,0 +1,3 @@
<!DOCTYPE html>
<title>Truncated text and inline-blocks combined should not cause a panic</title>
<div style="width: 100px; height: 100px; background: green"></div>