Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 07:13:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implement HTMLBaseElement attributes

Browse source
This commit is contained in:
Keith Yeung 2016-04-10 15:54:49 -04:00
parent a4991f536c
commit 4a1eb47937
7 changed files with 33 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

30
components/script/dom/htmlbaseelement.rs
View file

@ -2,8 +2,9 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
use dom::attr::Attr;
use dom::attr::{Attr, AttrValue};
use dom::bindings::codegen::Bindings::HTMLBaseElementBinding;
use dom::bindings::codegen::Bindings::HTMLBaseElementBinding::HTMLBaseElementMethods;
use dom::bindings::inheritance::Castable;
use dom::bindings::js::Root;
use dom::document::Document;
@ -60,6 +61,33 @@ impl HTMLBaseElement {
}
}
impl HTMLBaseElementMethods for HTMLBaseElement {
// https://html.spec.whatwg.org/multipage/#dom-base-href
fn Href(&self) -> DOMString {
let document = document_from_node(self);
// Step 1.
if !self.upcast::<Element>().has_attribute(&atom!("href")) {
return DOMString::from(document.base_url().serialize());
}
// Step 2.
let fallback_base_url = document.fallback_base_url();
// Step 3.
let url = self.upcast::<Element>().get_url_attribute(&atom!("href"));
// Step 4.
let url_record = fallback_base_url.join(&*url);
// Step 5, 6.
DOMString::from(url_record.ok().map_or("".to_owned(), |record| record.serialize()))
}
// https://html.spec.whatwg.org/multipage/#dom-base-href
make_url_setter!(SetHref, "href");
}
impl VirtualMethods for HTMLBaseElement {
fn super_type(&self) -> Option<&VirtualMethods> {
Some(self.upcast::<HTMLElement>() as &VirtualMethods)

2
components/script/dom/webidls/HTMLBaseElement.webidl
View file

@ -5,6 +5,6 @@
// https://html.spec.whatwg.org/multipage/#htmlbaseelement
interface HTMLBaseElement : HTMLElement {
// attribute DOMString href;
attribute DOMString href;
// attribute DOMString target;
};

5
tests/wpt/metadata/XMLHttpRequest/open-url-base-inserted.htm.ini
View file

@ -1,5 +0,0 @@
[open-url-base-inserted.htm]
type: testharness
[XMLHttpRequest: open() resolving URLs - insert ]
expected: FAIL

10
tests/wpt/metadata/html/dom/interfaces.html.ini
View file

@ -1977,16 +1977,13 @@
[HTMLHtmlElement interface: document.createElement("html") must inherit property "version" with the proper type (0)]
expected: FAIL
[HTMLBaseElement interface: attribute href]
expected: FAIL
[HTMLBaseElement interface: attribute target]
expected: FAIL
[HTMLBaseElement interface: document.createElement("base") must inherit property "href" with the proper type (0)]
[HTMLBaseElement interface: document.createElement("base") must inherit property "target" with the proper type (1)]
expected: FAIL
[HTMLBaseElement interface: document.createElement("base") must inherit property "target" with the proper type (1)]
[HTMLLinkElement interface: attribute crossOrigin]
expected: FAIL
[HTMLLinkElement interface: attribute sizes]
@ -8904,6 +8901,3 @@
[Document interface: new Document() must inherit property "onwaiting" with the proper type (156)]
expected: FAIL
[HTMLLinkElement interface: attribute crossOrigin]
expected: FAIL

8
tests/wpt/metadata/html/semantics/document-metadata/the-base-element/base_href_empty.html.ini
View file

@ -1,8 +0,0 @@
[base_href_empty.html]
type: testharness
[The value of the href attribute must be the document's address if it is empty]
expected: FAIL
[The src attribute of the img element must relative to document's address]
expected: FAIL

5
tests/wpt/metadata/html/semantics/document-metadata/the-base-element/base_href_specified.sub.html.ini
View file

@ -1,5 +0,0 @@
[base_href_specified.sub.html]
type: testharness
[The href attribute of the base element is specified]
expected: FAIL

8
tests/wpt/metadata/html/semantics/document-metadata/the-base-element/base_href_unspecified.html.ini
View file

@ -1,8 +0,0 @@
[base_href_unspecified.html]
type: testharness
[The value of the href attribute must be the document's address if it is unspecified]
expected: FAIL
[The src attribute of the img element must relative to document's address]
expected: FAIL