From 4a97d6f4a0487071d599b4c3b670a28c4ef868c5 Mon Sep 17 00:00:00 2001 From: Mats Palmgren Date: Mon, 30 Sep 2019 17:32:52 +0000 Subject: [PATCH] style: Implement 'repeat(auto-fill, )' in subgridded axis. Differential Revision: https://phabricator.services.mozilla.com/D46895 --- components/style/values/generics/grid.rs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/components/style/values/generics/grid.rs b/components/style/values/generics/grid.rs index 29f634d10fe..807136d98c4 100644 --- a/components/style/values/generics/grid.rs +++ b/components/style/values/generics/grid.rs @@ -646,11 +646,8 @@ impl Parse for LineNameList { if let Ok((mut names_list, count)) = repeat_parse_result { match count { - // FIXME(emilio): we probably shouldn't expand repeat() at - // parse time for subgrid. - // - // Also this doesn't have the merging semantics that - // non-subgrid has... But maybe that's ok? + // FIXME(emilio): we shouldn't expand repeat() at + // parse time for subgrid. (bug 1583429) RepeatCount::Number(num) => line_names.extend( names_list .iter() @@ -660,6 +657,8 @@ impl Parse for LineNameList { ), RepeatCount::AutoFill if fill_idx.is_none() => { // `repeat(autof-fill, ..)` should have just one line name. + // FIXME(bug 1341507) the above comment is wrong per: + // https://drafts.csswg.org/css-grid-2/#typedef-name-repeat if names_list.len() != 1 { return Err( input.new_custom_error(StyleParseErrorKind::UnspecifiedError)