Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-27 23:30:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

constellation: Use one image cache thread pool in the single-process mode (#38783)

Browse source 
Previously, each ScriptThread was creating a new image cache with a
separate thread pool. These changes add an image cache to the
constellation and create new image caches by calling the
`create_new_image_cache` method. It reuses the original image cache's
thread pool and reduces the number of spawned threads in the
single-process mode.

Testing: Tested manually, using `ps -M` to see the number of spawned
threads with multiple tabs open in servoshell before and after these
changes.
Fixes: #37770

Signed-off-by: Rodion Borovyk <rodion.borovyk@gmail.com>
This commit is contained in:
Rodion Borovyk 2025-09-12 14:35:26 +02:00 • committed by GitHub
parent 23ac24438a
commit 4aabc67e57
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 30 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

19
components/constellation/pipeline.rs
View file

@ -212,6 +212,9 @@ pub struct InitialPipelineState {
/// A list of URLs that can access privileged internal APIs.
pub privileged_urls: Vec<ServoUrl>,
/// The image cache for the single-process mode
pub image_cache: Arc<dyn ImageCache>,
}
pub struct NewPipeline {
@ -338,6 +341,7 @@ impl Pipeline {
false,
state.layout_factory,
register,
Some(state.image_cache),
);
(None, None, Some(join_handle))
};
@ -517,15 +521,20 @@ impl UnprivilegedPipelineContent {
wait_for_completion: bool,
layout_factory: Arc<dyn LayoutFactory>,
background_hang_monitor_register: Box<dyn BackgroundHangMonitorRegister>,
image_cache: Option<Arc<dyn ImageCache>>,
) -> JoinHandle<()> {
// Setup pipeline-namespace-installing for all threads in this process.
// Idempotent in single-process mode.
PipelineNamespace::set_installer_sender(self.namespace_request_sender);
let image_cache = Arc::new(ImageCacheImpl::new(
self.cross_process_compositor_api.clone(),
self.rippy_data,
));
let image_cache = image_cache.unwrap_or_else(|| {
// Create a new image cache (in the multiprocess case)
Arc::new(ImageCacheImpl::new(
self.cross_process_compositor_api.clone(),
self.rippy_data,
))
});
let (content_process_shutdown_chan, content_process_shutdown_port) = unbounded();
let join_handle = STF::create(
InitialScriptState {
@ -542,7 +551,7 @@ impl UnprivilegedPipelineContent {
#[cfg(feature = "bluetooth")]
bluetooth_sender: self.bluetooth_thread,
resource_threads: self.resource_threads,
image_cache: image_cache.clone(),
image_cache,
time_profiler_sender: self.time_profiler_chan.clone(),
memory_profiler_sender: self.mem_profiler_chan.clone(),
devtools_server_sender: self.devtools_ipc_sender,