mirror of
https://github.com/servo/servo.git
synced 2025-07-22 23:03:42 +01:00
Pass around event types as Atoms instead of Strings
`Event` internally stores the `type` as an `Atom`, and we're `String`s everywhere, which can cause unnecessary allocations to occur since they'll end up as `Atom`s anyways.
This commit is contained in:
parent
996c0a60b8
commit
4accaf50b2
25 changed files with 156 additions and 135 deletions
|
@ -144,7 +144,7 @@ impl HTMLIFrameElement {
|
|||
let _ar = JSAutoRequest::new(cx);
|
||||
let _ac = JSAutoCompartment::new(cx, window.reflector().get_jsobject().get());
|
||||
let mut detail = RootedValue::new(cx, UndefinedValue());
|
||||
let event_name = DOMString::from(event.name().to_owned());
|
||||
let event_name = Atom::from(event.name());
|
||||
self.build_mozbrowser_event_detail(event, cx, detail.handle_mut());
|
||||
CustomEvent::new(GlobalRef::Window(window.r()),
|
||||
event_name,
|
||||
|
@ -210,7 +210,7 @@ impl HTMLIFrameElement {
|
|||
// Step 4
|
||||
let window = window_from_node(self);
|
||||
let event = Event::new(GlobalRef::Window(window.r()),
|
||||
DOMString::from("load".to_owned()),
|
||||
atom!("load"),
|
||||
EventBubbles::DoesNotBubble,
|
||||
EventCancelable::NotCancelable);
|
||||
event.fire(self.upcast());
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue