From 4b736595d72f7d62ee039be04f66985d86c08d24 Mon Sep 17 00:00:00 2001 From: Boris Chiou Date: Thu, 22 Sep 2022 03:47:11 +0000 Subject: [PATCH] style: Drop the usage of @scroll-timeline from animation builder @scroll-timeline rule was removed from the spec and wpt, so it's safe to remove this from Gecko. Differential Revision: https://phabricator.services.mozilla.com/D157248 --- components/style/matching.rs | 8 ++++---- components/style/values/specified/box.rs | 7 ++----- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/components/style/matching.rs b/components/style/matching.rs index b01c756c5d9..ddf71a6f3c6 100644 --- a/components/style/matching.rs +++ b/components/style/matching.rs @@ -289,7 +289,7 @@ trait PrivateMatchMethods: TElement { let old_ui_style = old_style.get_ui(); - let keyframes_or_timeline_could_have_changed = context + let keyframes_could_have_changed = context .shared .traversal_flags .contains(TraversalFlags::ForCSSRuleChanges); @@ -299,9 +299,9 @@ trait PrivateMatchMethods: TElement { // element has or will have CSS animation style regardless of whether // the animation is running or not. // - // TODO: We should check which @keyframes/@scroll-timeline were added/changed/deleted and - // update only animations corresponding to those @keyframes/@scroll-timeline. - if keyframes_or_timeline_could_have_changed { + // TODO: We should check which @keyframes were added/changed/deleted and + // update only animations corresponding to those @keyframes. + if keyframes_could_have_changed { return true; } diff --git a/components/style/values/specified/box.rs b/components/style/values/specified/box.rs index e532855c1d6..8056d693a12 100644 --- a/components/style/values/specified/box.rs +++ b/components/style/values/specified/box.rs @@ -816,13 +816,10 @@ pub enum AnimationTimeline { /// Use default timeline. The animation’s timeline is a DocumentTimeline. Auto, /// The scroll-timeline name. - /// - /// Note: This could be the timeline name from @scroll-timeline rule, or scroll-timeline-name - /// from itself, its ancestors, or its previous siblings. - /// https://drafts.csswg.org/scroll-animations-1/rewrite#scroll-timelines-named + /// https://drafts.csswg.org/scroll-animations-1/#scroll-timelines-named Timeline(TimelineName), /// The scroll() notation. - /// https://drafts.csswg.org/scroll-animations-1/rewrite#scroll-notation + /// https://drafts.csswg.org/scroll-animations-1/#scroll-notation #[css(function)] Scroll( #[css(skip_if = "is_default")] ScrollAxis,