From 4c02ad00efd8bf043ef0233fb5148b9cb4e76a2c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Sat, 25 Nov 2017 02:06:36 +0100 Subject: [PATCH] style: Don't insert into the `seen` set before ignoring document colors. Otherwise we may stop honoring other colors in other cascade levels. Fixes: #19370 --- components/style/properties/properties.mako.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/components/style/properties/properties.mako.rs b/components/style/properties/properties.mako.rs index de650d52e3c..f1ddcd53b2b 100644 --- a/components/style/properties/properties.mako.rs +++ b/components/style/properties/properties.mako.rs @@ -3330,7 +3330,6 @@ where if seen.contains(physical_longhand_id) { continue } - seen.insert(physical_longhand_id); let mut declaration = match *declaration { PropertyDeclaration::WithVariables(id, ref unparsed) => { @@ -3376,6 +3375,8 @@ where } } + seen.insert(physical_longhand_id); + % if category_to_cascade_now == "early": if LonghandId::FontSize == longhand_id { font_size = Some(declaration.clone());