Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-12 00:45:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #14640 - upsuper:unset-storage, r=emilio

Browse source 
Store unset keyword as specified value

<!-- Please describe your changes on the following line: -->
`unset` keyword value should *not* be converted to something else during parsing. It is a specified-value time value, which should be preserved until computation.

WIP patch for seeing what tests would be broken and / or if there is necessary to add any new test.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14640)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2016-12-25 14:23:34 -08:00 • committed by GitHub
commit 4cd7321531
7 changed files with 64 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/wpt/metadata/MANIFEST.json
View file

@ -39677,6 +39677,12 @@
"deleted_reftests": {},
"items": {
"testharness": {
"css-values/unset-value-storage.html": [
{
"path": "css-values/unset-value-storage.html",
"url": "/css-values/unset-value-storage.html"
}
],
"cssom/CSSKeyframesRule.html": [
{
"path": "cssom/CSSKeyframesRule.html",

23
tests/wpt/web-platform-tests/css-values/unset-value-storage.html Normal file
View file

@ -0,0 +1,23 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>Storage of "unset" value</title>
<meta name="author" title="Xidorn Quan" href="https://www.upsuper.org">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<style>
div {
color: unset;
border: unset;
}
</style>
<body>
<div id="log"></div>
<script>
test(function() {
let properties = ["color", "border", "border-left", "border-color", "border-right-style"];
let style = document.styleSheets[0].cssRules[0].style;
for (let prop of properties) {
assert_equals(style.getPropertyValue(prop), "unset", `${prop} is expected to be "unset"`);
}
});
</script>