Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Bump layout data ref count in unsafe_set_layout_data

Browse source 
We need this or else we double-free the layout data box and crash.
This commit is contained in:
Keegan McAllister 2013-07-19 16:31:25 -07:00
parent 4fd6ad3d5c
commit 4d76e7570e
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/components/script/dom/node.rs
View file

@ -223,6 +223,10 @@ impl<'self, View> AbstractNode<View> {
/// Sets the layout data, unsafely casting the type as layout wishes. Only layout is allowed /// Sets the layout data, unsafely casting the type as layout wishes. Only layout is allowed
/// to call this. This is wildly unsafe and is therefore marked as such. /// to call this. This is wildly unsafe and is therefore marked as such.
pub unsafe fn unsafe_set_layout_data<T>(self, data: @mut T) { pub unsafe fn unsafe_set_layout_data<T>(self, data: @mut T) {
// Don't decrement the refcount on data, since we're giving it to the
// base structure.
cast::forget(data);
do self.with_mut_base |base| { do self.with_mut_base |base| {
base.layout_data = Some(transmute(data)) base.layout_data = Some(transmute(data))
} }