Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #24339 - servo:sharing-cache-size, r=emilio

Browse source 
Remove obsolete logic for LRUCache size

The LRUCache implementation has been replaced, and no longer requires a backing store larger than its capacity.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24339)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2019-10-10 00:45:14 -04:00 • committed by GitHub
commit 4ded3038c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
components/style/sharing/mod.rs
View file

@ -90,17 +90,14 @@ use uluru::{Entry, LRUCache};
mod checks; mod checks;
/// The amount of nodes that the style sharing candidate cache should hold at /// The amount of nodes that the style sharing candidate cache should hold at
/// most. We'd somewhat like 32, but ArrayDeque only implements certain backing /// most.
/// store sizes. A cache size of 32 would mean a backing store of 33, but
/// that's not an implemented size: we can do 32 or 40.
/// ///
/// The cache size was chosen by measuring style sharing and resulting /// The cache size was chosen by measuring style sharing and resulting
/// performance on a few pages; sizes up to about 32 were giving good sharing /// performance on a few pages; sizes up to about 32 were giving good sharing
/// improvements (e.g. 3x fewer styles having to be resolved than at size 8) and /// improvements (e.g. 3x fewer styles having to be resolved than at size 8) and
/// slight performance improvements. Sizes larger than 32 haven't really been /// slight performance improvements. Sizes larger than 32 haven't really been
/// tested. /// tested.
pub const SHARING_CACHE_SIZE: usize = 31; pub const SHARING_CACHE_SIZE: usize = 32;
const SHARING_CACHE_BACKING_STORE_SIZE: usize = SHARING_CACHE_SIZE + 1;
/// Opaque pointer type to compare ComputedValues identities. /// Opaque pointer type to compare ComputedValues identities.
#[derive(Clone, Debug, Eq, PartialEq)] #[derive(Clone, Debug, Eq, PartialEq)]
@ -426,7 +423,7 @@ impl<E: TElement> StyleSharingTarget<E> {
} }
struct SharingCacheBase<Candidate> { struct SharingCacheBase<Candidate> {
entries: LRUCache<[Entry<Candidate>; SHARING_CACHE_BACKING_STORE_SIZE]>, entries: LRUCache<[Entry<Candidate>; SHARING_CACHE_SIZE]>,
} }
impl<Candidate> Default for SharingCacheBase<Candidate> { impl<Candidate> Default for SharingCacheBase<Candidate> {