From 4e60412c6d1a54cd05b4ce75be1fc0e296d4ce69 Mon Sep 17 00:00:00 2001 From: Ms2ger Date: Mon, 16 Nov 2015 15:50:30 +0100 Subject: [PATCH] Remove the unused arguments to hit_test and mouse_over. I don't think this code is called when there is no document element, but I added assertions to make sure we notice in case I was wrong. --- components/layout/query.rs | 5 ++--- components/script/dom/document.rs | 21 +++++---------------- components/script/layout_interface.rs | 4 ++-- 3 files changed, 9 insertions(+), 21 deletions(-) diff --git a/components/layout/query.rs b/components/layout/query.rs index 562e8f93aef..9057ac91967 100644 --- a/components/layout/query.rs +++ b/components/layout/query.rs @@ -57,7 +57,7 @@ impl LayoutRPC for LayoutRPCImpl { } /// Requests the node containing the point of interest. - fn hit_test(&self, _: TrustedNodeAddress, point: Point2D) -> Result { + fn hit_test(&self, point: Point2D) -> Result { let point = Point2D::new(Au::from_f32_px(point.x), Au::from_f32_px(point.y)); let resp = { let &LayoutRPCImpl(ref rw_data) = self; @@ -82,8 +82,7 @@ impl LayoutRPC for LayoutRPCImpl { Err(()) } - fn mouse_over(&self, _: TrustedNodeAddress, point: Point2D) - -> Result { + fn mouse_over(&self, point: Point2D) -> Result { let mut mouse_over_list: Vec = vec!(); let point = Point2D::new(Au::from_f32_px(point.x), Au::from_f32_px(point.y)); { diff --git a/components/script/dom/document.rs b/components/script/dom/document.rs index af1c265a876..1b8b99d90ec 100644 --- a/components/script/dom/document.rs +++ b/components/script/dom/document.rs @@ -483,30 +483,19 @@ impl Document { } pub fn hit_test(&self, point: &Point2D) -> Option { - let root = self.GetDocumentElement(); - let root = match root.r() { - Some(root) => root, - None => return None, - }; - let root = root.upcast::(); - let address = match self.window.layout().hit_test(root.to_trusted_node_address(), *point) { + assert!(self.GetDocumentElement().is_some()); + match self.window.layout().hit_test(*point) { Ok(HitTestResponse(node_address)) => Some(node_address), Err(()) => { debug!("layout query error"); None } - }; - address + } } pub fn get_nodes_under_mouse(&self, point: &Point2D) -> Vec { - let root = self.GetDocumentElement(); - let root = match root.r() { - Some(root) => root, - None => return vec!(), - }; - let root = root.upcast::(); - match self.window.layout().mouse_over(root.to_trusted_node_address(), *point) { + assert!(self.GetDocumentElement().is_some()); + match self.window.layout().mouse_over(*point) { Ok(MouseOverResponse(node_address)) => node_address, Err(()) => vec!(), } diff --git a/components/script/layout_interface.rs b/components/script/layout_interface.rs index d18098bf6c1..8c49cbcfb5f 100644 --- a/components/script/layout_interface.rs +++ b/components/script/layout_interface.rs @@ -101,8 +101,8 @@ pub trait LayoutRPC { /// Requests the geometry of this node. Used by APIs such as `clientTop`. fn node_geometry(&self) -> NodeGeometryResponse; /// Requests the node containing the point of interest - fn hit_test(&self, node: TrustedNodeAddress, point: Point2D) -> Result; - fn mouse_over(&self, node: TrustedNodeAddress, point: Point2D) -> Result; + fn hit_test(&self, point: Point2D) -> Result; + fn mouse_over(&self, point: Point2D) -> Result; /// Query layout for the resolved value of a given CSS property fn resolved_style(&self) -> ResolvedStyleResponse; fn offset_parent(&self) -> OffsetParentResponse;