mirror of
https://github.com/servo/servo.git
synced 2025-06-11 01:50:10 +00:00
Warn about empty lines following an open brace.
This commit is contained in:
parent
3ab5c07559
commit
4ebc065cba
2 changed files with 8 additions and 2 deletions
|
@ -299,6 +299,7 @@ def check_rust(file_name, lines):
|
|||
whitespace = False
|
||||
|
||||
prev_use = None
|
||||
prev_open_brace = False
|
||||
current_indent = 0
|
||||
prev_crate = {}
|
||||
prev_mod = {}
|
||||
|
@ -342,10 +343,10 @@ def check_rust(file_name, lines):
|
|||
line = re.sub(r"'(\\.|[^\\'])*?'", "''", line)
|
||||
|
||||
# get rid of comments
|
||||
line = re.sub('//.*?$|/\*.*?$|^\*.*?$', '', line)
|
||||
line = re.sub('//.*?$|/\*.*?$|^\*.*?$', '//', line)
|
||||
|
||||
# get rid of attributes that do not contain =
|
||||
line = re.sub('^#[A-Za-z0-9\(\)\[\]_]*?$', '', line)
|
||||
line = re.sub('^#[A-Za-z0-9\(\)\[\]_]*?$', '#[]', line)
|
||||
|
||||
# flag this line if it matches one of the following regular expressions
|
||||
# tuple format: (pattern, format_message, filter_function(match, line))
|
||||
|
@ -401,6 +402,10 @@ def check_rust(file_name, lines):
|
|||
|
||||
yield (idx + 1, message.format(*match.groups(), **match.groupdict()))
|
||||
|
||||
if prev_open_brace and not line:
|
||||
yield (idx + 1, "found an empty line following a {")
|
||||
prev_open_brace = line.endswith("{")
|
||||
|
||||
# check alphabetical order of extern crates
|
||||
if line.startswith("extern crate "):
|
||||
# strip "extern crate " from the begin and ";" from the end
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue