Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-18 20:05:34 +01:00
Code Issues Projects Releases Packages Wiki Activity

imagebitmap: Add 'none' image orientation option (#37634)

Browse source 
The 'none' image orientation option was temporarily deprecated (in 2022)
according to HTML specification with the remark about going to be reused
with
a different meaning in future as the same semantics as CSS 'none'
image-orientation.

https://html.spec.whatwg.org/multipage/#dom-imagebitmapoptions-imageorientation-none
https://www.w3.org/TR/css-images-3/#valdef-image-orientation-none

Official MDN documentation added it back with new meaning (in 2024),
but it wasn't added back to HTML specification (still pending).

https://developer.mozilla.org/en-US/docs/Web/API/Window/createImageBitmap#none

At current moment this option is poor supported on all major browsers,
but there are some
existed WPT tests (ImageBitmap/WebGL) which are actively use it in
createImageBitmap() options.

Chromium (supported):
- stable: same as 'from-image' (but with deprecation warning)
- experimental: ignoring any orientation metadata

Firefox (supported as default option):
- stable: ignoring any orientation metadata ('from-image' do the same)

Testing: Improvements and fails (expects 'from-image' behaviour from
'none' option) in the following tests
-
html/canvas/element/manual/imagebitmap/createImageBitmap-exif-orientation_none.html
- webgl/tests/conformance/textures/misc/exif-orientation.html

Fixes (partialy): #34112

Signed-off-by: Andrei Volykhin <andrei.volykhin@gmail.com>
This commit is contained in:
Andrei Volykhin 2025-06-25 10:20:12 +03:00 • committed by GitHub
parent 922d4b83de
commit 4ee348a202
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 960 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

25
tests/wpt/meta/html/canvas/element/manual/imagebitmap/createImageBitmap-exif-orientation_none.html.ini vendored
View file

@ -1,25 +0,0 @@
[createImageBitmap-exif-orientation_none.html]
expected: ERROR
[createImageBitmap with Orientation 1]
expected: TIMEOUT
[createImageBitmap with Orientation 2]
expected: TIMEOUT
[createImageBitmap with Orientation 3]
expected: TIMEOUT
[createImageBitmap with Orientation 4]
expected: TIMEOUT
[createImageBitmap with Orientation 5]
expected: TIMEOUT
[createImageBitmap with Orientation 6]
expected: TIMEOUT
[createImageBitmap with Orientation 7]
expected: TIMEOUT
[createImageBitmap with Orientation 8]
expected: TIMEOUT