Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 13:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Issue 13363 - Step 1.2 of compiling event handler

Browse source 
When compiling event handlers, check whether scripting is enabled
and early return None/null if not.

https://html.spec.whatwg.org/multipage/
webappapis.html#getting-the-current-value-of-the-event-handler

Issue 13363 - Fix spec for disabled scripting

The original spec for this PR was bad because it depended on the
DOM without scripting enabled to use Javascript to signal the test's
failure, so it could never fail.

Use an onerror handler on `window` where scripting is enabled, and
use an invalid string of JavaScript for the handler, to detect
whether or not the event handler is *really* being compiled or not.

Condense tests into a single HTML file

Yup, didn't even realize I could do that at the time.

Remove an unnecessary test
This commit is contained in:
Jesse Kipp 2016-10-16 00:18:41 -04:00
parent 759185abe0
commit 4f0ffbd1f6
3 changed files with 31 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
components/script/dom/eventtarget.rs
View file

@ -373,7 +373,10 @@ impl EventTarget {
None => self.downcast::<Window>().unwrap().Document(),
};
// TODO step 1.2 (browsing context/scripting enabled)
// Step 1.2
if !document.is_scripting_enabled() {
return None;
}
// Step 1.3
let body: Vec<u16> = handler.source.encode_utf16().collect();

6
tests/wpt/metadata/MANIFEST.json
View file

@ -37756,6 +37756,12 @@
"path": "html/semantics/forms/the-select-element/common-HTMLOptionsCollection-add.html",
"url": "/html/semantics/forms/the-select-element/common-HTMLOptionsCollection-add.html"
}
],
"html/webappapis/scripting/events/uncompiled_event_handler_with_scripting_disabled.html": [
{
"path": "html/webappapis/scripting/events/uncompiled_event_handler_with_scripting_disabled.html",
"url": "/html/webappapis/scripting/events/uncompiled_event_handler_with_scripting_disabled.html"
}
]
}
},

21
tests/wpt/web-platform-tests/html/webappapis/scripting/events/uncompiled_event_handler_with_scripting_disabled.html Normal file
View file

@ -0,0 +1,21 @@
<!doctype html>
<meta charset="utf-8">
<title>Uncompiled event handler check that scripting is enabled</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>
setup({ allow_uncaught_exception: true });
test(function() {
var invoked = false;
window.addEventListener("error", function() {
invoked = true;
});
// Make sure that `this_will_error` will in fact error when it's referenced
assert_equals(typeof this_will_error, "undefined");
var dom = (new DOMParser()).parseFromString("<div id=\"has-event-handler\" onclick=\"this_will_error;\"></div>", "text/html");
var click = new MouseEvent("click");
dom.getElementById("has-event-handler").dispatchEvent(click);
assert_equals(invoked, false);
}, "when scripting is disabled, the handler is never compiled");
</script>