Remove unnecessary always succeed flag

This commit is contained in:
cybai 2022-08-16 00:18:37 +09:00
parent 49d94cb08b
commit 4f446f8c85

View file

@ -535,16 +535,13 @@ class MachCommands(CommandBase):
help='The API endpoint for tracking known intermittent failures.') help='The API endpoint for tracking known intermittent failures.')
@CommandArgument('--reporter-api', default=None, action='store', @CommandArgument('--reporter-api', default=None, action='store',
help='The API endpoint for reporting tracked intermittent failures.') help='The API endpoint for reporting tracked intermittent failures.')
@CommandArgument('--always-succeed', default=False, action='store_true',
help='Always yield exit code of zero')
def filter_intermittents(self, def filter_intermittents(self,
summary, summary,
log_filteredsummary, log_filteredsummary,
log_intermittents, log_intermittents,
auth, auth,
tracker_api, tracker_api,
reporter_api, reporter_api):
always_succeed):
encoded_auth = None encoded_auth = None
if auth: if auth:
with open(auth, "r") as file: with open(auth, "r") as file:
@ -611,10 +608,7 @@ class MachCommands(CommandBase):
if actual_failures: if actual_failures:
format(actual_failures, description) format(actual_failures, description)
if always_succeed: return bool(actual_failures)
return 0
else:
return bool(actual_failures)
@Command('test-android-startup', @Command('test-android-startup',
description='Extremely minimal testing of Servo for Android', description='Extremely minimal testing of Servo for Android',