Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-16 10:55:34 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #24044 - Eijebong:img-element-spec-update, r=jdm

Browse source 
Remove <img>'s historical progress events

Fixes #24011

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24044)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2019-09-02 21:29:14 -04:00 • committed by GitHub
commit 4f4e219e54
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/wpt/metadata/MANIFEST.json
View file

@ -640951,7 +640951,7 @@
"support"
],
"html/semantics/embedded-content/the-img-element/invalid-src.html": [
"c3c57ee3c0a05019be4db6650eeefdd53648401e",
"37ea8ce754a3feaa3e305f10899632d231c92363",
"testharness"
],
"html/semantics/embedded-content/the-img-element/ismap/img-ismap-coordinates-iframe-after.html": [

4
tests/wpt/metadata/html/semantics/embedded-content/the-img-element/historical-progress-event.window.js.ini
View file

@ -1,4 +0,0 @@
[historical-progress-event.window.html]
[<img> does not support ProgressEvent or loadstart/progress/loadend]
expected: FAIL

22
tests/wpt/web-platform-tests/html/semantics/embedded-content/the-img-element/invalid-src.html
View file

@ -9,41 +9,23 @@
async_test(function(t) {
var img = document.getElementById("brokenurl");
img.src = "http://[";
var errorevent = false;
var loadendevent = false;
// The errors should be queued in the event loop, so they should only trigger
// after this block of code finishes, not during the img.src setter itself
img.addEventListener('error', t.step_func(function() {
assert_false(loadendevent, "loadend should fire after error");
errorevent = true;
t.step_timeout(t.step_func_done(function() {
assert_true(loadendevent, "loadend event fired");
}), 0);
}));
img.addEventListener('loadend', t.step_func(function() {
assert_true(errorevent, "error event fired");
loadendevent = true;
t.step_timeout(t.step_func_done(), 0);
}));
}, 'src="http://["');
async_test(function(t) {
var img = document.getElementById("emptysrc");
img.src = "";
var loadendevent = false;
// Setting src to empty string triggers only error event.
// The errors should be queued in the event loop, so they should only trigger
// after this block of code finishes, not during the img.src setter itself
img.addEventListener('error', t.step_func(function() {
// Queue this check in the event loop to check there is no loadend event
// fired.
t.step_timeout(t.step_func_done(function() {
assert_false(loadendevent, "loadend event should not be fired");
}), 0);
}));
img.addEventListener('loadend', t.step_func(function() {
loadendevent = true;
t.step_timeout(t.step_func_done(), 0);
}));
}, 'src=""');