Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

First steps of &JSRef -> JSRef conversion

Browse source 
Replace &JSRef with JSRef in the bulk of the generated code. This will
remove a level of indirection throughout all DOM code.

This patch doesn't change methods implemented on JSRef<T> to take `self`
rather than `&self`, and it leaves a few other uses of &JSRef, but those
changes can be made incrementally.
This commit is contained in:
Cameron Zwarich 2014-09-18 13:43:15 -07:00
parent b8f34bbc51
commit 4fa8725111
126 changed files with 994 additions and 992 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/script/dom/domparser.rs
View file

@ -21,15 +21,15 @@ pub struct DOMParser {
}
impl DOMParser {
pub fn new_inherited(window: &JSRef<Window>) -> DOMParser {
pub fn new_inherited(window: JSRef<Window>) -> DOMParser {
DOMParser {
window: JS::from_rooted(window),
reflector_: Reflector::new()
}
}
pub fn new(window: &JSRef<Window>) -> Temporary<DOMParser> {
reflect_dom_object(box DOMParser::new_inherited(window), &Window(*window),
pub fn new(window: JSRef<Window>) -> Temporary<DOMParser> {
reflect_dom_object(box DOMParser::new_inherited(window), &Window(window),
DOMParserBinding::Wrap)
}
@ -46,10 +46,10 @@ impl<'a> DOMParserMethods for JSRef<'a, DOMParser> {
let window = self.window.root();
match ty {
Text_html => {
Ok(Document::new(&window.root_ref(), None, HTMLDocument, Some("text/html".to_string())))
Ok(Document::new(*window, None, HTMLDocument, Some("text/html".to_string())))
}
Text_xml => {
Ok(Document::new(&window.root_ref(), None, NonHTMLDocument, Some("text/xml".to_string())))
Ok(Document::new(*window, None, NonHTMLDocument, Some("text/xml".to_string())))
}
_ => {
Err(FailureUnknown)