Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

First steps of &JSRef -> JSRef conversion

Browse source 
Replace &JSRef with JSRef in the bulk of the generated code. This will
remove a level of indirection throughout all DOM code.

This patch doesn't change methods implemented on JSRef<T> to take `self`
rather than `&self`, and it leaves a few other uses of &JSRef, but those
changes can be made incrementally.
This commit is contained in:
Cameron Zwarich 2014-09-18 13:43:15 -07:00
parent b8f34bbc51
commit 4fa8725111
126 changed files with 994 additions and 992 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/script/dom/uievent.rs
View file

@ -40,13 +40,13 @@ impl UIEvent {
}
}
pub fn new_uninitialized(window: &JSRef<Window>) -> Temporary<UIEvent> {
pub fn new_uninitialized(window: JSRef<Window>) -> Temporary<UIEvent> {
reflect_dom_object(box UIEvent::new_inherited(UIEventTypeId),
&Window(*window),
&Window(window),
UIEventBinding::Wrap)
}
pub fn new(window: &JSRef<Window>,
pub fn new(window: JSRef<Window>,
type_: DOMString,
can_bubble: bool,
cancelable: bool,
@ -54,7 +54,7 @@ impl UIEvent {
detail: i32) -> Temporary<UIEvent> {
let ev = UIEvent::new_uninitialized(window).root();
ev.deref().InitUIEvent(type_, can_bubble, cancelable, view, detail);
Temporary::from_rooted(&*ev)
Temporary::from_rooted(*ev)
}
pub fn Constructor(global: &GlobalRef,
@ -82,7 +82,7 @@ impl<'a> UIEventMethods for JSRef<'a, UIEvent> {
cancelable: bool,
view: Option<JSRef<Window>>,
detail: i32) {
let event: &JSRef<Event> = EventCast::from_ref(self);
let event: JSRef<Event> = EventCast::from_ref(*self);
event.InitEvent(type_, can_bubble, cancelable);
self.view.assign(view);
self.detail.deref().set(detail);