From 4fb53c8256fc5b770255b47d9b60cdc540b9838b Mon Sep 17 00:00:00 2001 From: Florian Duraffourg Date: Tue, 17 May 2016 10:13:47 +0200 Subject: [PATCH] Correct cookie handling behavior - Cookies with empty values are not to be ignored as per RFC6265 - A space should separate two cookie-pairs as per RFC6265 section 4.2.1 --- components/net/cookie_storage.rs | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/components/net/cookie_storage.rs b/components/net/cookie_storage.rs index 0698b8e46cd..7482481bad1 100644 --- a/components/net/cookie_storage.rs +++ b/components/net/cookie_storage.rs @@ -58,10 +58,6 @@ impl CookieStorage { return; } - if cookie.cookie.value.is_empty() { - return; - } - // Step 11 if let Some(old_cookie) = old_cookie.unwrap() { // Step 11.3 @@ -108,7 +104,7 @@ impl CookieStorage { // Step 4 (match acc.len() { 0 => acc, - _ => acc + ";" + _ => acc + "; " }) + &c.cookie.name + "=" + &c.cookie.value }; let result = url_cookies.iter_mut().fold("".to_owned(), reducer);