From 4fe106cffc015cd36fc80dafb192f52a87dd36f0 Mon Sep 17 00:00:00 2001 From: Oriol Brufau Date: Mon, 30 Jun 2025 09:06:44 +0200 Subject: [PATCH] layout: Remove wrong depends_on_block_constraints logic (#37761) `FlexContainer::layout()` was forcing `depends_on_block_constraints` to true for `flex-direction: column`. However, it doesn't make sense to do that only for `column` but not for `column-reverse`. Also no test is complaining, so I'm just removing that logic. Testing: no behavior change is intended, so just existing test coverage Signed-off-by: Oriol Brufau --- components/layout/flexbox/layout.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/components/layout/flexbox/layout.rs b/components/layout/flexbox/layout.rs index 51e05053fdb..85489981c8d 100644 --- a/components/layout/flexbox/layout.rs +++ b/components/layout/flexbox/layout.rs @@ -17,7 +17,6 @@ use style::logical_geometry::Direction; use style::properties::ComputedValues; use style::properties::longhands::align_items::computed_value::T as AlignItems; use style::properties::longhands::box_sizing::computed_value::T as BoxSizing; -use style::properties::longhands::flex_direction::computed_value::T as FlexDirection; use style::properties::longhands::flex_wrap::computed_value::T as FlexWrap; use style::values::computed::LengthPercentage; use style::values::generics::flex::GenericFlexBasis as FlexBasis; @@ -640,9 +639,6 @@ impl FlexContainer { depends_on_block_constraints: bool, lazy_block_size: &LazySize, ) -> CacheableLayoutResult { - let depends_on_block_constraints = - depends_on_block_constraints || self.config.flex_direction == FlexDirection::Column; - let mut flex_context = FlexContext { config: self.config.clone(), layout_context,