From 4ff4b5833def0eae3aa809bb287d2b6916e50bfb Mon Sep 17 00:00:00 2001 From: Ms2ger Date: Fri, 11 Jul 2014 13:16:07 +0200 Subject: [PATCH] Test for missing newlines at end of file in tidy.py. --- src/components/script/dom/bindings/str.rs | 2 +- src/components/script/dom/file.rs | 2 +- src/components/script/dom/urlsearchparams.rs | 2 +- src/etc/tidy.py | 3 +++ 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/components/script/dom/bindings/str.rs b/src/components/script/dom/bindings/str.rs index 09b327dafa1..b42845b6e77 100644 --- a/src/components/script/dom/bindings/str.rs +++ b/src/components/script/dom/bindings/str.rs @@ -139,4 +139,4 @@ impl FromStr for ByteString { fn from_str(s: &str) -> Option { Some(ByteString::new(s.container_into_owned_bytes())) } -} \ No newline at end of file +} diff --git a/src/components/script/dom/file.rs b/src/components/script/dom/file.rs index ecaee0976f9..731f76770be 100644 --- a/src/components/script/dom/file.rs +++ b/src/components/script/dom/file.rs @@ -50,4 +50,4 @@ impl Reflectable for File { fn reflector<'a>(&'a self) -> &'a Reflector { self.blob.reflector() } -} \ No newline at end of file +} diff --git a/src/components/script/dom/urlsearchparams.rs b/src/components/script/dom/urlsearchparams.rs index 0455cc673a7..862945c1e03 100644 --- a/src/components/script/dom/urlsearchparams.rs +++ b/src/components/script/dom/urlsearchparams.rs @@ -151,4 +151,4 @@ impl URLSearchParamsHelpers for URLSearchParams { // XXXManishearth Implement this when the URL interface is implemented // http://url.spec.whatwg.org/#concept-uq-update } -} \ No newline at end of file +} diff --git a/src/etc/tidy.py b/src/etc/tidy.py index c0cdb1eb433..c49bdf657e9 100644 --- a/src/etc/tidy.py +++ b/src/etc/tidy.py @@ -31,6 +31,9 @@ def do_whitespace_check(name, contents): for idx, line in enumerate(contents): if line[-1] == "\n": line = line[:-1] + else: + report_error_name_no(name, idx + 1, "No newline at EOF") + if line.endswith(' '): report_error_name_no(name, idx + 1, "trailing whitespace")