Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 13:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Cap the number of style threads at six.

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D1928
Bug: 1431285
Reviewed-by: emilio
This commit is contained in:
Bobby Holley 2018-07-03 23:47:48 +00:00 • committed by Emilio Cobos Álvarez
parent c23dca874f
commit 50a85a5dd6
No known key found for this signature in database
GPG key ID: 056B727BB9C1027C
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
components/style/gecko/global_style_data.rs
View file

@ -65,7 +65,12 @@ lazy_static! {
.map(|s| s.parse::<usize>().expect("invalid STYLO_THREADS value"));
let mut num_threads = match stylo_threads {
Ok(num) => num,
_ => cmp::max(num_cpus::get() * 3 / 4, 1),
// The default heuristic is num_virtual_cores * .75. This gives us
// three threads on a hyper-threaded dual core, and six threads on
// a hyper-threaded quad core. The performance benefit of additional
// threads seems to level off at around six, so we cap it there on
// many-core machines (see bug 1431285 comment 14).
_ => cmp::min(cmp::max(num_cpus::get() * 3 / 4, 1), 6),
};
// If num_threads is one, there's no point in creating a thread pool, so