Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 21:20:23 +01:00
Code Issues Projects Releases Packages Wiki Activity

Test <video> with width and height attributes but aspect-ratio:auto (#34069)

Browse source 
See https://github.com/servo/servo/pull/31746#discussion_r1805234405

Signed-off-by: Oriol Brufau <obrufau@igalia.com>
This commit is contained in:
Oriol Brufau 2024-10-30 12:59:37 +01:00 • committed by GitHub
parent 850e59f98e
commit 517e8a376a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 63 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/wpt/meta/MANIFEST.json vendored
View file

@ -687087,7 +687087,7 @@
] ]
], ],
"video-aspect-ratio.html": [ "video-aspect-ratio.html": [
"119523d250ffc215ceb04738e7f49c01f06c60a1", "0686fba93ea07f695333fbced26c7f27bfa3aec3",
[ [
null, null,
{} {}

106
tests/wpt/tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html vendored
View file

@ -14,9 +14,14 @@
<body> <body>
<video width="250" height="100" id="contained" style="contain: size;"></video> <video width="250" height="100" id="contained" style="contain: size;"></video>
<script> <script>
function assert_ratio(img, expected) { function assert_ratio(element, expected, description) {
let epsilon = 0.001; let epsilon = 0.001;
assert_approx_equals(parseInt(getComputedStyle(img).width, 10) / parseInt(getComputedStyle(img).height, 10), expected, epsilon); assert_approx_equals(
parseFloat(getComputedStyle(element).width) / parseFloat(getComputedStyle(element).height),
expected,
epsilon,
description,
);
} }
function test_computed_style(width, height, expected) { function test_computed_style(width, height, expected) {
@ -24,49 +29,62 @@ function test_computed_style(width, height, expected) {
} }
promise_test(async function() { promise_test(async function() {
{ let video = document.getElementById("contained");
let video = document.getElementById("contained"); video.src = getVideoURI('/media/2x2-green');
video.src = getVideoURI('/media/2x2-green'); assert_ratio(video, 2.5);
assert_ratio(video, 2.5, "contain:size aspect ratio"); }, "Aspect ratio for video with contain:size");
}
// Create and append a new video and immediately check the ratio. // Create and append a new video and immediately check the ratio.
// This is not racy because the spec requires the user agent to queue a task: // This is not racy because the spec requires the user agent to queue a task:
// https://html.spec.whatwg.org/multipage/media.html#concept-media-load-algorithm // https://html.spec.whatwg.org/multipage/media.html#concept-media-load-algorithm
{ promise_test(async function() {
let video = document.createElement("video"); let video = document.createElement("video");
video.setAttribute("width", "250"); video.setAttribute("width", "250");
video.setAttribute("height", "100"); video.setAttribute("height", "100");
video.src = getVideoURI('/media/2x2-green'); video.src = getVideoURI('/media/2x2-green');
document.body.appendChild(video); document.body.appendChild(video);
assert_ratio(video, 2.5, "aspect ratio for regular video before load"); assert_ratio(video, 2.5, "aspect ratio before load");
await new Promise(r => video.addEventListener("loadeddata", r, { once: true })); await new Promise(r => video.addEventListener("loadeddata", r, { once: true }));
// When loaded this video is square. // When loaded this video is square.
assert_ratio(video, 1, "aspect ratio for regular video after load"); assert_ratio(video, 1, "aspect ratio after load");
} }, "Aspect ratio for regular video");
// Same but with auto width. // Same but with auto width.
{ promise_test(async function() {
let video = document.createElement("video"); let video = document.createElement("video");
video.setAttribute("width", "250"); video.setAttribute("width", "250");
video.setAttribute("height", "100"); video.setAttribute("height", "100");
video.style.width = "auto"; video.style.width = "auto";
video.src = getVideoURI('/media/2x2-green'); video.src = getVideoURI('/media/2x2-green');
document.body.appendChild(video); document.body.appendChild(video);
assert_ratio(video, 2.5, "aspect ratio for regular video with width: auto before load"); assert_ratio(video, 2.5, "aspect ratio before load");
await new Promise(r => video.addEventListener("loadeddata", r, { once: true })); await new Promise(r => video.addEventListener("loadeddata", r, { once: true }));
assert_ratio(video, 1, "aspect ratio for regular video with width: auto after load"); assert_ratio(video, 1, "aspect ratio after load");
} }, "Aspect ratio for regular video with width:auto");
test_computed_style("10", "20", "auto 10 / 20"); // Same but with auto aspect-ratio.
test_computed_style("0.5", "1.5", "auto 0.5 / 1.5"); promise_test(async function() {
test_computed_style("0", "1", "auto 0 / 1"); let video = document.createElement("video");
test_computed_style("1", "0", "auto 1 / 0"); video.setAttribute("width", "250");
test_computed_style("0", "0", "auto 0 / 0"); video.setAttribute("height", "100");
test_computed_style(null, null, "auto"); video.style.aspectRatio = "auto";
test_computed_style("10", null, "auto"); video.src = getVideoURI('/media/2x2-green');
test_computed_style(null, "20", "auto"); document.body.appendChild(video);
test_computed_style("xx", "20", "auto"); // The aspect ratio is 2 because the default size is 300x150.
test_computed_style("10%", "20", "auto"); assert_ratio(video, 2, "aspect ratio before load");
}); await new Promise(r => video.addEventListener("loadeddata", r, { once: true }));
// But now we can use the natural ratio from the video source.
assert_ratio(video, 1, "aspect ratio after load");
}, "Aspect ratio for regular video with aspect-ratio:auto");
test_computed_style("10", "20", "auto 10 / 20");
test_computed_style("0.5", "1.5", "auto 0.5 / 1.5");
test_computed_style("0", "1", "auto 0 / 1");
test_computed_style("1", "0", "auto 1 / 0");
test_computed_style("0", "0", "auto 0 / 0");
test_computed_style(null, null, "auto");
test_computed_style("10", null, "auto");
test_computed_style(null, "20", "auto");
test_computed_style("xx", "20", "auto");
test_computed_style("10%", "20", "auto");
</script> </script>