Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

Register pipeline instead of browsing contexts for media instances

Browse source
This commit is contained in:
Fernando Jiménez Moreno 2019-09-17 23:04:38 +02:00
parent 7b653cad7b
commit 51ed44c77d
4 changed files with 24 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

18
components/script/dom/offlineaudiocontext.rs
View file

@ -23,7 +23,7 @@ use crate::dom::promise::Promise;
use crate::dom::window::Window;
use crate::task_source::TaskSource;
use dom_struct::dom_struct;
use msg::constellation_msg::BrowsingContextId;
use msg::constellation_msg::PipelineId;
use servo_media::audio::context::OfflineAudioContextOptions as ServoMediaOfflineAudioContextOptions;
use std::cell::Cell;
use std::rc::Rc;
@ -47,7 +47,7 @@ impl OfflineAudioContext {
channel_count: u32,
length: u32,
sample_rate: f32,
browsing_context_id: BrowsingContextId,
pipeline_id: PipelineId,
) -> OfflineAudioContext {
let options = ServoMediaOfflineAudioContextOptions {
channels: channel_count as u8,
@ -56,7 +56,7 @@ impl OfflineAudioContext {
};
let context = BaseAudioContext::new_inherited(
BaseAudioContextOptions::OfflineAudioContext(options),
browsing_context_id,
pipeline_id,
);
OfflineAudioContext {
context,
@ -82,13 +82,11 @@ impl OfflineAudioContext {
{
return Err(Error::NotSupported);
}
let browsing_context_id = window.window_proxy().top_level_browsing_context_id().0;
let context = OfflineAudioContext::new_inherited(
channel_count,
length,
sample_rate,
browsing_context_id,
);
let pipeline_id = window
.pipeline_id()
.expect("Cannot create audio context outside of a pipeline");
let context =
OfflineAudioContext::new_inherited(channel_count, length, sample_rate, pipeline_id);
Ok(reflect_dom_object(
Box::new(context),
window,